Skip to content

[dev] size-limit bot problems #4775

@lobsterkatie

Description

@lobsterkatie

[Note: These problems aren't unique to our repo, but they affect it, so it might make sense for either our team or @kamilogorek to tackle this. Also, https://github.com/getsentry/size-limit-action doesn't let you create issues.]

Two problems with the size-limit bot:

  1. The comparison can be misleading, because AFAICT it always compares to master's HEAD commit, not the branch's base commit.

  2. The skip_step config option never worked in the original size-limit action, and it similarly doesn't work for our fork. It's hard to figure out why - the code is very straightforward (see here) - but for some reason even though we've told it to skip the build step(here), it never does sometimes doesn't.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions