-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
Description
[Note: These problems aren't unique to our repo, but they affect it, so it might make sense for either our team or @kamilogorek to tackle this. Also, https://github.com/getsentry/size-limit-action doesn't let you create issues.]
Two problems with the size-limit bot:
-
The comparison can be misleading, because AFAICT it always compares to master's HEAD commit, not the branch's base commit.
-
The
skip_stepconfig option never worked in the original size-limit action, and it similarly doesn't work for our fork. It's hard to figure out why - the code is very straightforward (see here) - but for some reason even though we've told it to skip the build step(here), itnever doessometimes doesn't.