Merge default options when using manual initialization in @sentry/vue

[micopiira]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other: @sentry/vue

Version:

6.11.0

Description

Following the documentation for Vue 3 Manual initializition gives error

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at __values (tslib.es6.js:196)
    at Object.createTracingMixins (tracing.js:94)

Manually passing the hooks option to createTracingMixins seems to get rid of the error so I guess the default options are not getting merged to the passed options correctly?

Codesandbox reproduction here: https://codesandbox.io/s/pensive-tereshkova-nfn7x

[kamilogorek]

hooks are required option. We should make it more clear to non-TS users and make a better default -

sentry-javascript/packages/vue/src/types.ts

Lines 61 to 66 in 949f1b6

	/**
	* List of hooks to keep track of during component lifecycle.
	* Available hooks: 'activate' | 'create' | 'destroy' | 'mount' | 'unmount' | 'update'
	* Based on https://vuejs.org/v2/api/#Options-Lifecycle-Hooks
	*/
	hooks: Operation[];

[micopiira]

In that case I think the documentation is misleading.

The SDK accepts a few different configuration options that let you change its behavior:
...

• hooks (defaults to ['activate', 'mount', 'update']) - List of hooks to keep track of during component lifecycle 'activate' | 'create' | 'destroy' | 'mount' | 'unmount' | 'update'.

I would expect the passed options to be merged with the defaults, but apparently that is not the case.

[kamilogorek]

You are correct. This should be fixed.