Suggestion to change Sentry.flush behaviour to resolve instead of reject for not initialized client.

[vdanchenkov]

Is far as I understand it's normal to not call Sentry.init in development env. Sentry.captureMessage and Sentry.captureException methods tolerate it and do nothing when called.

When deployed to AWS you have to call await Sentry.flush(n) (as suggested in many guides) to make sure that all data is sent, but this code throws exception if Sentry was not initialized.

[larose]

I think the fix is to change:

sentry-javascript/packages/node/src/sdk.ts

Line 146 in cca6fcf

return Promise.reject(false);

to:

return false;

because return Promise.reject(false); is equivalent to throw false;.

The following functions are also affected:

sentry-javascript/packages/node/src/sdk.ts

Line 160 in cca6fcf

return Promise.reject(false);

sentry-javascript/packages/browser/src/sdk.ts

Line 149 in cca6fcf

return SyncPromise.reject(false);

sentry-javascript/packages/browser/src/sdk.ts

Line 163 in cca6fcf

return SyncPromise.reject(false);