Skip to content

Commit f4f42c5

Browse files
authored
test(nextjs): Remove Next 13 and pin Next 14 canary and latest tests (#17577)
Looks like we tested canary and latest versions of NextJS 13 and 14 in a way that we'd actually always pull in the latest 15 (canary) versions. This PR fixes this by: - removing Next 13 canary tests (these haven't been updated in more than 2 years) - Pinning Next 13 latest to `@next-13` - Pining Next 14 canary to `~14.3.0-canary.0` - Pinning Next 14 latest to `@next-14`
1 parent a820fa2 commit f4f42c5

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

.github/workflows/canary.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,6 @@ jobs:
8181
- test-application: 'nextjs-app-dir'
8282
build-command: 'test:build-latest'
8383
label: 'nextjs-app-dir (latest)'
84-
- test-application: 'nextjs-13'
85-
build-command: 'test:build-canary'
86-
label: 'nextjs-13 (canary)'
8784
- test-application: 'nextjs-13'
8885
build-command: 'test:build-latest'
8986
label: 'nextjs-13 (latest)'

dev-packages/e2e-tests/test-applications/nextjs-13/package.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
"test:prod": "TEST_ENV=production playwright test",
99
"test:dev": "TEST_ENV=development playwright test",
1010
"test:build": "pnpm install && pnpm build",
11-
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
12-
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
11+
"test:build-latest": "pnpm install && pnpm add next@next-13 && pnpm build",
1312
"test:assert": "pnpm test:prod && pnpm test:dev"
1413
},
1514
"dependencies": {
@@ -31,10 +30,6 @@
3130
},
3231
"sentryTest": {
3332
"optionalVariants": [
34-
{
35-
"build-command": "pnpm test:build-canary",
36-
"label": "nextjs-13 (canary)"
37-
},
3833
{
3934
"build-command": "pnpm test:build-latest",
4035
"label": "nextjs-13 (latest)"

dev-packages/e2e-tests/test-applications/nextjs-14/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"test:prod": "TEST_ENV=production playwright test",
99
"test:dev": "TEST_ENV=development playwright test",
1010
"test:build": "pnpm install && pnpm build",
11-
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
12-
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
11+
"test:build-canary": "pnpm install && pnpm add next@~14.3.0-canary.0 && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
12+
"test:build-latest": "pnpm install && pnpm add next@next-14 && pnpm build",
1313
"test:assert": "pnpm test:prod && pnpm test:dev"
1414
},
1515
"dependencies": {

0 commit comments

Comments
 (0)