remove transport from session flusher

Author: AbhiPrasad

packages/hub/src/sessionflusher.ts

@@ -1,10 +1,4 @@
-import {
-  AggregationCounts,
-  RequestSessionStatus,
-  SessionAggregates,
-  SessionFlusherLike,
-  Transport,
-} from '@sentry/types';
+import { AggregationCounts, Client, RequestSessionStatus, SessionAggregates, SessionFlusherLike } from '@sentry/types';
 import { dropUndefinedKeys, logger } from '@sentry/utils';
 
 import { IS_DEBUG_BUILD } from './flags';
@@ -24,22 +18,18 @@ export class SessionFlusher implements SessionFlusherLike {
   private _sessionAttrs: ReleaseHealthAttributes;
   private _intervalId: ReturnType<typeof setInterval>;
   private _isEnabled: boolean = true;
-  private _transport: Transport;
+  private _client: Client;
 
-  public constructor(transport: Transport, attrs: ReleaseHealthAttributes) {
-    this._transport = transport;
+  public constructor(client: Client, attrs: ReleaseHealthAttributes) {
+    this._client = client;
     // Call to setInterval, so that flush is called every 60 seconds
     this._intervalId = setInterval(() => this.flush(), this.flushTimeout * 1000);
     this._sessionAttrs = attrs;
   }
 
   /** Sends session aggregates to Transport */
   public sendSessionAggregates(sessionAggregates: SessionAggregates): void {
-    if (!this._transport.sendSession) {
-      IS_DEBUG_BUILD && logger.warn("Dropping session because custom transport doesn't implement sendSession");
-      return;
-    }
-    void this._transport.sendSession(sessionAggregates).then(null, reason => {
+    void this._client.sendSession(sessionAggregates).then(null, reason => {
       IS_DEBUG_BUILD && logger.error('Error while sending session:', reason);
     });
   }

packages/node/src/client.ts

@@ -99,7 +99,7 @@ export class NodeClient extends BaseClient<NodeClientOptions> {
     if (!release) {
       IS_DEBUG_BUILD && logger.warn('Cannot initialise an instance of SessionFlusher if no release is provided!');
     } else {
-      this._sessionFlusher = new SessionFlusher(this.getTransport(), {
+      this._sessionFlusher = new SessionFlusher(this, {
         release,
         environment,
       });

packages/types/src/client.ts

@@ -3,7 +3,7 @@ import { Event, EventHint } from './event';
 import { Integration, IntegrationClass } from './integration';
 import { ClientOptions } from './options';
 import { Scope } from './scope';
-import { Session } from './session';
+import { Session, SessionAggregates } from './session';
 import { Severity, SeverityLevel } from './severity';
 import { NewTransport } from './transport';
 
@@ -116,5 +116,5 @@ export interface Client<O extends ClientOptions = ClientOptions> {
   sendEvent(event: Event): void;
 
   /** Submits the session to Sentry */
-  sendSession(session: Session): void;
+  sendSession(session: Session | SessionAggregates): void;
 }