rename to forceTransaction

Author: mydea

packages/core/src/tracing/trace.ts

@@ -36,7 +36,7 @@ export function startSpan<T>(context: StartSpanOptions, callback: (span: Span |
       : createChildSpanOrTransaction(hub, {
           parentSpan,
           spanContext,
-          isTransaction: context.isTransaction,
+          forceTransaction: context.forceTransaction,
           scope,
         });
 
@@ -85,7 +85,7 @@ export function startSpanManual<T>(
       : createChildSpanOrTransaction(hub, {
           parentSpan,
           spanContext,
-          isTransaction: context.isTransaction,
+          forceTransaction: context.forceTransaction,
           scope,
         });
 
@@ -147,7 +147,7 @@ export function startInactiveSpan(context: StartSpanOptions): Span | undefined {
   return createChildSpanOrTransaction(hub, {
     parentSpan,
     spanContext,
-    isTransaction: context.isTransaction,
+    forceTransaction: context.forceTransaction,
     scope: temporaryScope,
   });
 }
@@ -267,12 +267,12 @@ function createChildSpanOrTransaction(
   {
     parentSpan,
     spanContext,
-    isTransaction,
+    forceTransaction,
     scope,
   }: {
     parentSpan: Span | undefined;
     spanContext: TransactionContext;
-    isTransaction?: boolean;
+    forceTransaction?: boolean;
     scope: Scope;
   },
 ): Span | undefined {
@@ -283,7 +283,7 @@ function createChildSpanOrTransaction(
   const isolationScope = getIsolationScope();
 
   let span: Span | undefined;
-  if (parentSpan && !isTransaction) {
+  if (parentSpan && !forceTransaction) {
     // eslint-disable-next-line deprecation/deprecation
     span = parentSpan.startChild(spanContext);
     addChildSpanToSpan(parentSpan, span);

packages/core/test/lib/tracing/trace.test.ts

@@ -333,7 +333,7 @@ describe('startSpan', () => {
     expect(getActiveSpan()).toBe(undefined);
   });
 
-  it('allows to force a transaction with isTransaction=true', async () => {
+  it('allows to force a transaction with forceTransaction=true', async () => {
     const options = getDefaultTestClientOptions({ tracesSampleRate: 1.0 });
     client = new TestClient(options);
     setCurrentClient(client);
@@ -350,7 +350,7 @@ describe('startSpan', () => {
 
     startSpan({ name: 'outer transaction' }, () => {
       startSpan({ name: 'inner span' }, () => {
-        startSpan({ name: 'inner transaction', isTransaction: true }, () => {
+        startSpan({ name: 'inner transaction', forceTransaction: true }, () => {
           startSpan({ name: 'inner span 2' }, () => {
             // all good
           });
@@ -623,7 +623,7 @@ describe('startSpanManual', () => {
     expect(getActiveSpan()).toBe(undefined);
   });
 
-  it('allows to force a transaction with isTransaction=true', async () => {
+  it('allows to force a transaction with forceTransaction=true', async () => {
     const options = getDefaultTestClientOptions({ tracesSampleRate: 1.0 });
     client = new TestClient(options);
     setCurrentClient(client);
@@ -640,7 +640,7 @@ describe('startSpanManual', () => {
 
     startSpanManual({ name: 'outer transaction' }, span => {
       startSpanManual({ name: 'inner span' }, span => {
-        startSpanManual({ name: 'inner transaction', isTransaction: true }, span => {
+        startSpanManual({ name: 'inner transaction', forceTransaction: true }, span => {
           startSpanManual({ name: 'inner span 2' }, span => {
             // all good
             span?.end();
@@ -852,7 +852,7 @@ describe('startInactiveSpan', () => {
     expect(getActiveSpan()).toBeUndefined();
   });
 
-  it('allows to force a transaction with isTransaction=true xxx', async () => {
+  it('allows to force a transaction with forceTransaction=true xxx', async () => {
     const options = getDefaultTestClientOptions({ tracesSampleRate: 1.0 });
     client = new TestClient(options);
     setCurrentClient(client);
@@ -869,7 +869,7 @@ describe('startInactiveSpan', () => {
 
     startSpan({ name: 'outer transaction' }, () => {
       startSpan({ name: 'inner span' }, () => {
-        const innerTransaction = startInactiveSpan({ name: 'inner transaction', isTransaction: true });
+        const innerTransaction = startInactiveSpan({ name: 'inner transaction', forceTransaction: true });
         innerTransaction?.end();
       });
     });

packages/types/src/startSpanOptions.ts

@@ -20,8 +20,8 @@ export interface StartSpanOptions extends TransactionContext {
   /** An op for the span. This is a categorization for spans. */
   op?: string;
 
-  /** If set to true, this span will be treated as a transaction in the Sentry UI. */
-  isTransaction?: boolean;
+  /** If set to true, this span will be forced to be treated as a transaction in the Sentry UI. */
+  forceTransaction?: boolean;
 
   /**
    * The origin of the span - if it comes from auto instrumentation or manual instrumentation.