fix(node): Prioritize globalAgent while figuring out protocol.

Author: onurtemizkan

packages/node/src/integrations/utils/http.ts

@@ -152,9 +152,9 @@ export function normalizeRequestArgs(
     // Worst case we end up populating protocol with undefined, which it already is
     /* eslint-disable @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any */
     requestOptions.protocol =
+      (httpModule?.globalAgent as any)?.protocol ||
       (requestOptions.agent as any)?.protocol ||
-      (requestOptions._defaultAgent as any)?.protocol ||
-      (httpModule?.globalAgent as any)?.protocol;
+      (requestOptions._defaultAgent as any)?.protocol
     /* eslint-enable @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-explicit-any */
   }
 

packages/node/test/integrations/http.test.ts

@@ -6,6 +6,7 @@ import { parseSemver } from '@sentry/utils';
 import * as http from 'http';
 import * as https from 'https';
 import * as nock from 'nock';
+import * as HttpsProxyAgent from "https-proxy-agent";
 
 import { Breadcrumb } from '../../src';
 import { NodeClient } from '../../src/client';
@@ -175,4 +176,31 @@ describe('default protocols', () => {
     const b = await p;
     expect(b.data?.url).toEqual(expect.stringContaining('https://'));
   });
+
+  it('makes https request over http proxy', async () => {
+    const key = 'catcatchers';
+    const p = captureBreadcrumb(key);
+    let nockProtocol = 'https:';
+
+    const proxy = "http://<PROXY_URL>:3128";
+    const agent = new HttpsProxyAgent(proxy);
+
+    if (NODE_VERSION.major && NODE_VERSION.major < 9) {
+      nockProtocol = 'http:';
+    }
+
+    nock(`${nockProtocol}://${key}.ingest.sentry.io`)
+      .get('/api/123122332/store/')
+      .reply(200);
+
+    https.get({
+      host: `${key}.ingest.sentry.io`,
+      path: '/api/123122332/store/',
+      timeout: 300,
+      agent
+    });
+
+    const b = await p;
+    expect(b.data?.url).toEqual(expect.stringContaining('https://'));
+  })
 });