adress review

Author: Luca Forstner

packages/react/src/redux.ts

@@ -108,19 +108,17 @@ function createReduxEnhancer(enhancerOptions?: Partial<SentryEnhancerOptions>):
           if (typeof transformedState !== 'undefined' && transformedState !== null) {
             const client = getCurrentHub().getClient();
             const options = client && client.getOptions();
-            const normalizationDepth = options && options.normalizeDepth;
+            const normalizationDepth = (options && options.normalizeDepth) || 3; // default state normalization depth to 3
 
             // Set the normalization depth of the redux state to the configured `normalizeDepth` option or a sane number as a fallback
+            const newStateContext = { state: { type: 'redux', value: transformedState } };
             addNonEnumerableProperty(
-              transformedState,
+              newStateContext,
               '__sentry_override_normalization_depth__',
-              normalizationDepth || 3,
+              3 + // 3 layers for `state.value.transformedState`
+                normalizationDepth, // rest for the actual state
             );
 
-            // Make sure the state is always reached during normalization
-            const newStateContext = { state: { type: 'redux', value: transformedState } };
-            addNonEnumerableProperty(newStateContext, '__sentry_override_normalization_depth__', 3);
-
             scope.setContext('state', newStateContext);
           } else {
             scope.setContext('state', null);

packages/utils/src/normalize.ts

@@ -105,7 +105,7 @@ function visit(
   // have already been normalized.
   let overriddenDepth = depth;
 
-  if ((value as ObjOrArray<unknown>)['__sentry_override_normalization_depth__']) {
+  if (typeof (value as ObjOrArray<unknown>)['__sentry_override_normalization_depth__'] === 'number') {
     overriddenDepth = (value as ObjOrArray<unknown>)['__sentry_override_normalization_depth__'] as number;
   }