feat: Parse safari-extension and safari-web-extension errors (#3374)

Author: kamilogorek

packages/browser/src/tracekit.ts

@@ -120,11 +120,24 @@ function computeStackTraceFromStackProp(ex: any): StackTrace | null {
         parts[3] = submatch[2]; // line
         parts[4] = submatch[3]; // column
       }
+
+      // Arpad: Working with the regexp above is super painful. it is quite a hack, but just stripping the `address at `
+      // prefix here seems like the quickest solution for now.
+      let url = parts[2] && parts[2].indexOf('address at ') === 0 ? parts[2].substr('address at '.length) : parts[2];
+
+      // Kamil: One more hack won't hurt us right? Understanding and adding more rules on top of these regexps right now
+      // would be way too time consuming. (TODO: Rewrite whole RegExp to be more readable)
+      let func = parts[1] || UNKNOWN_FUNCTION;
+      const isSafariExtension = func.indexOf('safari-extension') !== -1;
+      const isSafariWebExtension = func.indexOf('safari-web-extension') !== -1;
+      if (isSafariExtension || isSafariWebExtension) {
+        func = func.indexOf('@') !== -1 ? func.split('@')[0] : UNKNOWN_FUNCTION;
+        url = isSafariExtension ? `safari-extension:${url}` : `safari-web-extension:${url}`;
+      }
+
       element = {
-        // working with the regexp above is super painful. it is quite a hack, but just stripping the `address at `
-        // prefix here seems like the quickest solution for now.
-        url: parts[2] && parts[2].indexOf('address at ') === 0 ? parts[2].substr('address at '.length) : parts[2],
-        func: parts[1] || UNKNOWN_FUNCTION,
+        url,
+        func,
         args: isNative ? [parts[2]] : [],
         line: parts[3] ? +parts[3] : null,
         column: parts[4] ? +parts[4] : null,

packages/browser/test/unit/tracekit/custom.test.ts

@@ -24,6 +24,60 @@ describe('Tracekit - Custom Tests', () => {
     ]);
   });
 
+  it('should parse exceptions for safari-extension', () => {
+    const SAFARI_EXTENSION_EXCEPTION = {
+      message: 'wat',
+      name: 'Error',
+      stack: `Error: wat
+      at ClipperError@safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:223036:10)
+      at safari-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/topee-content.js:3313:26)`,
+    };
+    const stacktrace = computeStackTrace(SAFARI_EXTENSION_EXCEPTION);
+    expect(stacktrace.stack).deep.equal([
+      {
+        url: 'safari-extension://3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js',
+        func: 'ClipperError',
+        args: [],
+        line: 223036,
+        column: 10,
+      },
+      {
+        url: 'safari-extension://3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/topee-content.js',
+        func: '?',
+        args: [],
+        line: 3313,
+        column: 26,
+      },
+    ]);
+  });
+
+  it('should parse exceptions for safari-web-extension', () => {
+    const SAFARI_WEB_EXTENSION_EXCEPTION = {
+      message: 'wat',
+      name: 'Error',
+      stack: `Error: wat
+      at ClipperError@safari-web-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js:223036:10)
+      at safari-web-extension:(//3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/topee-content.js:3313:26)`,
+    };
+    const stacktrace = computeStackTrace(SAFARI_WEB_EXTENSION_EXCEPTION);
+    expect(stacktrace.stack).deep.equal([
+      {
+        url: 'safari-web-extension://3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/commons.js',
+        func: 'ClipperError',
+        args: [],
+        line: 223036,
+        column: 10,
+      },
+      {
+        url: 'safari-web-extension://3284871F-A480-4FFC-8BC4-3F362C752446/2665fee0/topee-content.js',
+        func: '?',
+        args: [],
+        line: 3313,
+        column: 26,
+      },
+    ]);
+  });
+
   it('should parse exceptions for react-native-v8', () => {
     const REACT_NATIVE_V8_EXCEPTION = {
       message: 'Manually triggered crash to test Sentry reporting',