Skip to content

Commit ead53ec

Browse files
AbhiPrasadAbhiPrasad
committed
fix tests
1 parent 154c251 commit ead53ec

File tree

5 files changed

+22
-50
lines changed

5 files changed

+22
-50
lines changed

‎dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/assets/sentry-logo-600x179.png‎

15.7 KB
Loading

‎dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/template.html‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22
<html>
33
<head>
44
<meta charset="utf-8" />
5+
<script>
6+
// Simulate a long task to delay the TTFB
7+
async function run() {
8+
await fetch('https://example.com/path/to/image.png');
9+
}
10+
run();
11+
</script>
512
</head>
613
<body>
714
<div>Rendered</div>

‎dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/test.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import type { Route } from '@playwright/test';
12
import { expect } from '@playwright/test';
23
import type { Event } from '@sentry/types';
34

@@ -10,9 +11,14 @@ sentryTest('should capture TTFB vital.', async ({ getLocalTestPath, page }) => {
1011
}
1112

1213
page.route('**', async route => {
13-
await new Promise(resolve => setTimeout(resolve, 3000));
14+
await new Promise(resolve => setTimeout(resolve, 1000));
1415
route.continue();
1516
});
17+
page.route('**/path/to/image.png', async (route: Route) => {
18+
// Simulate a delay in the response to make sure we capture the TTFB vital.
19+
await new Promise(resolve => setTimeout(resolve, 1000));
20+
return route.fulfill({ path: `${__dirname}/assets/sentry-logo-600x179.png` });
21+
});
1622

1723
const url = await getLocalTestPath({ testDir: __dirname });
1824
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);

‎packages/tracing-internal/src/browser/metrics/index.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -544,10 +544,10 @@ function _addTtfbRequestTimeToMeasurements(_measurements: Measurements): void {
544544
const navEntry = getNavigationEntry() as TTFBMetric['entries'][number];
545545
const { responseStart, requestStart } = navEntry;
546546

547-
if (requestStart <= responseStart) {
548-
DEBUG_BUILD && logger.log('[Measurements] Adding TTFB');
547+
if (responseStart > requestStart) {
548+
DEBUG_BUILD && logger.log('[Measurements] Adding TTFB Request Time');
549549
_measurements['ttfb.requestTime'] = {
550-
value: (responseStart - requestStart) * 1000,
550+
value: responseStart - requestStart,
551551
unit: 'millisecond',
552552
};
553553
}

‎yarn.lock‎

Lines changed: 5 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -6712,17 +6712,7 @@
67126712
dependencies:
67136713
"@types/unist" "*"
67146714

6715-
"@types/history-4@npm:@types/[email protected]":
6716-
version "4.7.8"
6717-
resolved "https://registry.yarnpkg.com/@types/history/-/history-4.7.8.tgz#49348387983075705fe8f4e02fb67f7daaec4934"
6718-
integrity sha512-S78QIYirQcUoo6UJZx9CSP0O2ix9IaeAXwQi26Rhr/+mg7qqPy8TzaxHSUut7eGjL8WmLccT7/MXf304WjqHcA==
6719-
6720-
"@types/history-5@npm:@types/[email protected]":
6721-
version "4.7.8"
6722-
resolved "https://registry.yarnpkg.com/@types/history/-/history-4.7.8.tgz#49348387983075705fe8f4e02fb67f7daaec4934"
6723-
integrity sha512-S78QIYirQcUoo6UJZx9CSP0O2ix9IaeAXwQi26Rhr/+mg7qqPy8TzaxHSUut7eGjL8WmLccT7/MXf304WjqHcA==
6724-
6725-
"@types/history@*":
6715+
"@types/history-4@npm:@types/[email protected]", "@types/history-5@npm:@types/[email protected]", "@types/history@*":
67266716
version "4.7.8"
67276717
resolved "https://registry.yarnpkg.com/@types/history/-/history-4.7.8.tgz#49348387983075705fe8f4e02fb67f7daaec4934"
67286718
integrity sha512-S78QIYirQcUoo6UJZx9CSP0O2ix9IaeAXwQi26Rhr/+mg7qqPy8TzaxHSUut7eGjL8WmLccT7/MXf304WjqHcA==
@@ -7112,15 +7102,7 @@
71127102
"@types/history" "^3"
71137103
"@types/react" "*"
71147104

7115-
"@types/react-router-4@npm:@types/[email protected]":
7116-
version "5.1.14"
7117-
resolved "https://registry.yarnpkg.com/@types/react-router/-/react-router-5.1.14.tgz#e0442f4eb4c446541ad7435d44a97f8fe6df40da"
7118-
integrity sha512-LAJpqYUaCTMT2anZheoidiIymt8MuX286zoVFPM3DVb23aQBH0mAkFvzpd4LKqiolV8bBtZWT5Qp7hClCNDENw==
7119-
dependencies:
7120-
"@types/history" "*"
7121-
"@types/react" "*"
7122-
7123-
"@types/react-router-5@npm:@types/[email protected]":
7105+
"@types/react-router-4@npm:@types/[email protected]", "@types/react-router-5@npm:@types/[email protected]":
71247106
version "5.1.14"
71257107
resolved "https://registry.yarnpkg.com/@types/react-router/-/react-router-5.1.14.tgz#e0442f4eb4c446541ad7435d44a97f8fe6df40da"
71267108
integrity sha512-LAJpqYUaCTMT2anZheoidiIymt8MuX286zoVFPM3DVb23aQBH0mAkFvzpd4LKqiolV8bBtZWT5Qp7hClCNDENw==
@@ -25305,7 +25287,7 @@ react-is@^18.0.0:
2530525287
dependencies:
2530625288
"@remix-run/router" "1.0.2"
2530725289

25308-
"react-router-6@npm:[email protected]":
25290+
"react-router-6@npm:[email protected]", [email protected]:
2530925291
version "6.3.0"
2531025292
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.3.0.tgz#3970cc64b4cb4eae0c1ea5203a80334fdd175557"
2531125293
integrity sha512-7Wh1DzVQ+tlFjkeo+ujvjSqSJmkt1+8JO+T5xklPlgrh70y7ogx75ODRW0ThWhY7S+6yEDks8TYrtQe/aoboBQ==
@@ -25320,13 +25302,6 @@ react-router-dom@^6.2.2:
2532025302
history "^5.2.0"
2532125303
react-router "6.3.0"
2532225304

25323-
[email protected]:
25324-
version "6.3.0"
25325-
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.3.0.tgz#3970cc64b4cb4eae0c1ea5203a80334fdd175557"
25326-
integrity sha512-7Wh1DzVQ+tlFjkeo+ujvjSqSJmkt1+8JO+T5xklPlgrh70y7ogx75ODRW0ThWhY7S+6yEDks8TYrtQe/aoboBQ==
25327-
dependencies:
25328-
history "^5.2.0"
25329-
2533025305
react@^18.0.0:
2533125306
version "18.0.0"
2533225307
resolved "https://registry.yarnpkg.com/react/-/react-18.0.0.tgz#b468736d1f4a5891f38585ba8e8fb29f91c3cb96"
@@ -27806,7 +27781,7 @@ stringify-object@^3.2.1:
2780627781
is-obj "^1.0.1"
2780727782
is-regexp "^1.0.0"
2780827783

27809-
"strip-ansi-cjs@npm:strip-ansi@^6.0.1":
27784+
"strip-ansi-cjs@npm:strip-ansi@^6.0.1", strip-ansi@^6.0.0, strip-ansi@^6.0.1:
2781027785
version "6.0.1"
2781127786
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
2781227787
integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
@@ -27834,13 +27809,6 @@ strip-ansi@^5.1.0, strip-ansi@^5.2.0:
2783427809
dependencies:
2783527810
ansi-regex "^4.1.0"
2783627811

27837-
strip-ansi@^6.0.0, strip-ansi@^6.0.1:
27838-
version "6.0.1"
27839-
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-6.0.1.tgz#9e26c63d30f53443e9489495b2105d37b67a85d9"
27840-
integrity sha512-Y38VPSHcqkFrCpFnQ9vuSXmquuv5oXOKpGeT6aGrr3o3Gc9AlVa6JBfUSOCnbxGGZF+/0ooI7KrPuUSztUdU5A==
27841-
dependencies:
27842-
ansi-regex "^5.0.1"
27843-
2784427812
strip-ansi@^7.0.1:
2784527813
version "7.0.1"
2784627814
resolved "https://registry.yarnpkg.com/strip-ansi/-/strip-ansi-7.0.1.tgz#61740a08ce36b61e50e65653f07060d000975fb2"
@@ -30487,16 +30455,7 @@ workerpool@^6.4.0:
3048730455
resolved "https://registry.yarnpkg.com/workerpool/-/workerpool-6.4.0.tgz#f8d5cfb45fde32fa3b7af72ad617c3369567a462"
3048830456
integrity sha512-i3KR1mQMNwY2wx20ozq2EjISGtQWDIfV56We+yGJ5yDs8jTwQiLLaqHlkBHITlCuJnYlVRmXegxFxZg7gqI++A==
3048930457

30490-
"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0":
30491-
version "7.0.0"
30492-
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
30493-
integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==
30494-
dependencies:
30495-
ansi-styles "^4.0.0"
30496-
string-width "^4.1.0"
30497-
strip-ansi "^6.0.0"
30498-
30499-
[email protected], wrap-ansi@^5.1.0, wrap-ansi@^6.2.0, wrap-ansi@^7.0.0, wrap-ansi@^8.1.0:
30458+
"wrap-ansi-cjs@npm:wrap-ansi@^7.0.0", [email protected], wrap-ansi@^5.1.0, wrap-ansi@^6.2.0, wrap-ansi@^7.0.0, wrap-ansi@^8.1.0:
3050030459
version "7.0.0"
3050130460
resolved "https://registry.yarnpkg.com/wrap-ansi/-/wrap-ansi-7.0.0.tgz#67e145cff510a6a6984bdf1152911d69d2eb9e43"
3050230461
integrity sha512-YVGIj2kamLSTxw6NsZjoBxfSwsn0ycdesmc4p+Q21c5zPuZ1pl+NfxVdxPtdHvmNVOQ6XSYG4AUtyt/Fi7D16Q==

0 commit comments

Comments
 (0)