update tests and refactor

Author: c298lee

dev-packages/browser-integration-tests/suites/replay/customEvents/test.ts

@@ -8,6 +8,9 @@ import {
   expectedFIDPerformanceSpan,
   expectedFPPerformanceSpan,
   expectedLCPPerformanceSpan,
+  expectedCLSPerformanceSpan,
+  expectedFIDPerformanceSpan,
+  expectedINPPerformanceSpan,
   expectedMemoryPerformanceSpan,
   expectedNavigationPerformanceSpan,
   getExpectedReplayEvent,

dev-packages/browser-integration-tests/suites/replay/multiple-pages/test.ts

@@ -8,6 +8,9 @@ import {
   expectedFIDPerformanceSpan,
   expectedFPPerformanceSpan,
   expectedLCPPerformanceSpan,
+  expectedCLSPerformanceSpan,
+  expectedFIDPerformanceSpan,
+  expectedINPPerformanceSpan,
   expectedMemoryPerformanceSpan,
   expectedNavigationBreadcrumb,
   expectedNavigationPerformanceSpan,

packages/replay-internal/src/types/performance.ts

@@ -113,42 +113,6 @@ export interface WebVitalData {
   nodeId?: number;
 }
 
-export interface CumulativeLayoutShiftData {
-  /**
-   * Render time (in ms) of the CLS
-   */
-  value: number;
-  size: number;
-  /**
-   * The recording id of the CLS node. -1 if not found
-   */
-  nodeId?: number;
-}
-
-export interface FirstInputDelayData {
-  /**
-   * Render time (in ms) of the FID
-   */
-  value: number;
-  size: number;
-  /**
-   * The recording id of the FID node. -1 if not found
-   */
-  nodeId?: number;
-}
-
-export interface InteractionToNextPaintData {
-  /**
-   * Render time (in ms) of the INP
-   */
-  value: number;
-  size: number;
-  /**
-   * The recording id of the INP node. -1 if not found
-   */
-  nodeId?: number;
-}
-
 /**
  * Entries that come from window.performance
  */

packages/replay-internal/test/unit/util/createPerformanceEntry.test.ts

@@ -152,6 +152,7 @@ describe('Unit | util | createPerformanceEntries', () => {
     it('works with an CLS metric', async () => {
       const metric = {
         value: 5108.299,
+        rating: 'good' as const,
         entries: [],
       };
 
@@ -162,7 +163,7 @@ describe('Unit | util | createPerformanceEntries', () => {
         name: 'cumulative-layout-shift',
         start: 1672531205.108299,
         end: 1672531205.108299,
-        data: { value: 5108.299, size: 5108.299, nodeId: undefined },
+        data: { value: 5108.299, size: 5108.299, rating: 'good', nodeId: undefined },
       });
     });
   });
@@ -171,6 +172,7 @@ describe('Unit | util | createPerformanceEntries', () => {
     it('works with an FID metric', async () => {
       const metric = {
         value: 5108.299,
+        rating: 'good' as const,
         entries: [],
       };
 
@@ -181,7 +183,7 @@ describe('Unit | util | createPerformanceEntries', () => {
         name: 'first-input-delay',
         start: 1672531205.108299,
         end: 1672531205.108299,
-        data: { value: 5108.299, size: 5108.299, nodeId: undefined },
+        data: { value: 5108.299, size: 5108.299, rating: 'good', nodeId: undefined },
       });
     });
   });
@@ -190,6 +192,7 @@ describe('Unit | util | createPerformanceEntries', () => {
     it('works with an INP metric', async () => {
       const metric = {
         value: 5108.299,
+        rating: 'good' as const,
         entries: [],
       };