update error -> buffer

Author: billyvg

packages/browser-integration-tests/suites/replay/errors/errorMode/test.ts

@@ -16,7 +16,7 @@ import {
 } from '../../../../utils/replayHelpers';
 
 sentryTest(
-  '[error-mode] should start recording, only sample the 2nd error, and switch to session mode once an error is thrown',
+  '[error-mode] should start recording and switch to session mode once an error is thrown',
   async ({ getLocalTestPath, page, browserName }) => {
     // This was sometimes flaky on firefox/webkit, so skipping for now
     if (shouldSkipReplayTest() || ['firefox', 'webkit'].includes(browserName)) {

packages/replay/src/integration.ts

@@ -185,7 +185,7 @@ Sentry.init({ replaysOnErrorSampleRate: ${errorSampleRate} })`,
    * create a new session. Will throw an error if replay is already in progress.
    *
    * Creates or loads a session, attaches listeners to varying events (DOM,
-   * _performanceObserver, Recording, Sentry SDK, etc)
+   * PerformanceObserver, Recording, Sentry SDK, etc)
    */
   public start(): void {
     if (!this._replay) {

packages/replay/test/integration/coreHandlers/handleGlobalEvent.test.ts

@@ -1,5 +1,6 @@
 import type { Event } from '@sentry/types';
 
+import type { Replay as ReplayIntegration } from '../../../src';
 import { REPLAY_EVENT_NAME } from '../../../src/constants';
 import { handleGlobalEventListener } from '../../../src/coreHandlers/handleGlobalEvent';
 import type { ReplayContainer } from '../../../src/replay';
@@ -84,8 +85,10 @@ describe('Integration | coreHandlers | handleGlobalEvent', () => {
   });
 
   it('tags errors and transactions with replay id for session samples', async () => {
-    ({ replay } = await resetSdkMock({}));
-    replay.start();
+    let integration: ReplayIntegration;
+    ({ replay, integration } = await resetSdkMock({}));
+    // @ts-ignore protected but ok to use for testing
+    integration._initialize();
     const transaction = Transaction();
     const error = Error();
     expect(handleGlobalEventListener(replay)(transaction, {})).toEqual(

packages/replay/test/integration/errorSampleRate.test.ts

@@ -71,7 +71,7 @@ describe('Integration | errorSampleRate', () => {
     expect(replay).toHaveSentReplay({
       recordingPayloadHeader: { segment_id: 0 },
       replayEventPayload: expect.objectContaining({
-        replay_type: 'error',
+        replay_type: 'buffer',
         contexts: {
           replay: {
             error_sample_rate: 1,
@@ -103,7 +103,7 @@ describe('Integration | errorSampleRate', () => {
     expect(replay).toHaveLastSentReplay({
       recordingPayloadHeader: { segment_id: 1 },
       replayEventPayload: expect.objectContaining({
-        replay_type: 'error',
+        replay_type: 'buffer',
         contexts: {
           replay: {
             error_sample_rate: 1,
@@ -523,12 +523,15 @@ it('sends a replay after loading the session multiple times', async () => {
   // Pretend that a session is already saved before loading replay
   WINDOW.sessionStorage.setItem(
     REPLAY_SESSION_KEY,
-    `{"segmentId":0,"id":"fd09adfc4117477abc8de643e5a5798a","sampled":"error","started":${BASE_TIMESTAMP},"lastActivity":${BASE_TIMESTAMP}}`,
+    `{"segmentId":0,"id":"fd09adfc4117477abc8de643e5a5798a","sampled":"buffer","started":${BASE_TIMESTAMP},"lastActivity":${BASE_TIMESTAMP}}`,
   );
   const { mockRecord, replay, integration } = await resetSdkMock({
     replayOptions: {
       stickySession: true,
     },
+    sentryOptions: {
+      replaysOnErrorSampleRate: 1.0,
+    },
     autoStart: false,
   });
   // @ts-ignore this is protected, but we want to call it for this test
@@ -547,7 +550,6 @@ it('sends a replay after loading the session multiple times', async () => {
   await new Promise(process.nextTick);
   jest.advanceTimersByTime(DEFAULT_FLUSH_MIN_DELAY);
   await new Promise(process.nextTick);
-  await new Promise(process.nextTick);
 
   expect(replay).toHaveSentReplay({
     recordingData: JSON.stringify([{ data: { isCheckout: true }, timestamp: BASE_TIMESTAMP, type: 2 }, TEST_EVENT]),

packages/replay/test/unit/session/sessionSampling.test.ts

@@ -22,7 +22,7 @@ describe('Unit | session | sessionSampling', () => {
       sampled: getSessionSampleType(0, 1),
     });
 
-    expect(newSession.sampled).toBe('error');
+    expect(newSession.sampled).toBe('buffer');
   });
 
   it('does not run sampling function if existing session was sampled', function () {