no wiggle room

Author: mydea

dev-packages/browser-integration-tests/suites/replay/bufferModeManual/test.ts

@@ -350,7 +350,7 @@ sentryTest(
 );
 
 sentryTest(
-  '[buffer-mode] manually starting replay includes performance entries with 1s wiggle room',
+  '[buffer-mode] manually starting replay ignores earlier performance entries when starting immediately',
   async ({ getLocalTestUrl, page, browserName }) => {
     // This was sometimes flaky on webkit, so skipping for now
     if (shouldSkipReplayTest() || browserName === 'webkit') {
@@ -388,8 +388,21 @@ sentryTest(
 
     const { performanceSpans } = content0;
 
-    // web vitals etc. are included with 1s wiggle room, to accomodate "immediate" start
-    expect(performanceSpans.length).toBeGreaterThan(1);
+    expect(performanceSpans).toEqual([
+      {
+        op: 'memory',
+        description: 'memory',
+        startTimestamp: expect.any(Number),
+        endTimestamp: expect.any(Number),
+        data: {
+          memory: {
+            jsHeapSizeLimit: expect.any(Number),
+            totalJSHeapSize: expect.any(Number),
+            usedJSHeapSize: expect.any(Number),
+          },
+        },
+      },
+    ]);
   },
 );
 

packages/replay-internal/src/replay.ts

@@ -1052,14 +1052,13 @@ export class ReplayContainer implements ReplayContainerInterface {
     this.replayPerformanceEntries = [];
 
     // If we are manually starting, we want to ensure we only include performance entries
-    // that are after the initial timestamp, with 1s wiggle room.
+    // that are after the initial timestamp
     // The reason for this is that we may have performance entries from the page load, but may decide to start
     // the replay later on, in which case we do not want to include these entries.
     // without this, manually started replays can have events long before the actual replay recording starts,
     // which messes with the timeline etc.
     if (this._requiresManualStart) {
-      // We leave 1s wiggle room to accomodate timing differences for "immedidate" manual starts
-      const initialTimestampInSeconds = this._context.initialTimestamp / 1000 - 1;
+      const initialTimestampInSeconds = this._context.initialTimestamp / 1000;
       performanceEntries = performanceEntries.filter(entry => entry.start >= initialTimestampInSeconds);
     }