build: Switch types to using eslint

Author: AbhiPrasad

.eslintignore

@@ -8,6 +8,5 @@ packages/integrations/**/*
 packages/node/**/*
 packages/react/**/*
 packages/tracing/**/*
-packages/types/**/*
 packages/typescript/**/*
 packages/utils/**/*

packages/types/.eslintrc.js

@@ -0,0 +1,22 @@
+module.exports = {
+  root: true,
+  env: {
+    es6: true,
+  },
+  parserOptions: {
+    ecmaVersion: 2018,
+  },
+  extends: ['../../.eslintrc.js'],
+  ignorePatterns: ['build/**/*', 'dist/**/*', 'esm/**/*', 'examples/**/*', 'scripts/**/*'],
+  overrides: [
+    {
+      files: ['*.ts', '*.tsx', '*.d.ts'],
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+    },
+  ],
+  rules: {
+    '@typescript-eslint/no-explicit-any': 'off',
+  },
+};

packages/types/package.json

@@ -19,7 +19,6 @@
     "npm-run-all": "^4.1.2",
     "prettier": "^1.17.0",
     "prettier-check": "^2.0.0",
-    "tslint": "5.16.0",
     "typescript": "3.4.5"
   },
   "scripts": {
@@ -30,13 +29,13 @@
     "build:watch:es5": "tsc -p tsconfig.build.json -w --preserveWatchOutput",
     "build:watch:esm": "tsc -p tsconfig.esm.json -w --preserveWatchOutput",
     "link:yarn": "yarn link",
-    "lint": "run-s lint:prettier lint:tslint",
+    "lint": "run-s lint:prettier lint:eslint",
     "lint:prettier": "prettier-check \"{src,test}/**/*.ts\"",
-    "lint:tslint": "tslint -t stylish -p .",
-    "lint:tslint:json": "tslint --format json -p . | tee lint-results.json",
-    "fix": "run-s fix:tslint fix:prettier",
+    "lint:eslint": "eslint . --format stylish",
+    "lint:eslint:json": "eslint . --format json | tee lint-results.json",
+    "fix": "run-s fix:eslint fix:prettier",
     "fix:prettier": "prettier --write \"{src,test}/**/*.ts\"",
-    "fix:tslint": "tslint --fix -t stylish -p ."
+    "fix:eslint": "lint:eslint --fix"
   },
   "sideEffects": false
 }

packages/types/src/event.ts

@@ -32,7 +32,7 @@ export interface Event {
   stacktrace?: Stacktrace;
   breadcrumbs?: Breadcrumb[];
   contexts?: {
-    [key: string]: object;
+    [key: string]: Record<any, any>;
   };
   tags?: { [key: string]: string };
   extra?: { [key: string]: any };

packages/types/src/integration.ts

@@ -3,11 +3,12 @@ import { Hub } from './hub';
 
 /** Integration Class Interface */
 export interface IntegrationClass<T> {
-  new (...args: any[]): T;
   /**
    * Property that holds the integration name
    */
   id: string;
+
+  new (...args: any[]): T;
 }
 
 /** Integration interface */

packages/types/src/options.ts

@@ -105,6 +105,19 @@ export interface Options {
    */
   normalizeDepth?: number;
 
+  /**
+   * Controls how many milliseconds to wait before shutting down. The default is
+   * SDK-specific but typically around 2 seconds. Setting this too low can cause
+   * problems for sending events from command line applications. Setting it too
+   * high can cause the application to block for users with network connectivity
+   * problems.
+   */
+  shutdownTimeout?: number;
+
+  _experiments?: {
+    [key: string]: any;
+  };
+
   /**
    * A callback invoked during event submission, allowing to optionally modify
    * the event before it is sent to Sentry.
@@ -131,17 +144,4 @@ export interface Options {
    * @returns The breadcrumb that will be added | null.
    */
   beforeBreadcrumb?(breadcrumb: Breadcrumb, hint?: BreadcrumbHint): Breadcrumb | null;
-
-  /**
-   * Controls how many milliseconds to wait before shutting down. The default is
-   * SDK-specific but typically around 2 seconds. Setting this too low can cause
-   * problems for sending events from command line applications. Setting it too
-   * high can cause the application to block for users with network connectivity
-   * problems.
-   */
-  shutdownTimeout?: number;
-
-  _experiments?: {
-    [key: string]: any;
-  };
 }

packages/types/src/severity.ts

@@ -15,8 +15,8 @@ export enum Severity {
   /** JSDoc */
   Critical = 'critical',
 }
-// tslint:disable:completed-docs
-// tslint:disable:no-unnecessary-qualifier no-namespace
+
+// eslint-disable-next-line @typescript-eslint/no-namespace
 export namespace Severity {
   /**
    * Converts a string-based level into a {@link Severity}.

packages/types/src/status.ts

@@ -13,8 +13,8 @@ export enum Status {
   /** A server-side error ocurred during submission. */
   Failed = 'failed',
 }
-// tslint:disable:completed-docs
-// tslint:disable:no-unnecessary-qualifier no-namespace
+
+// eslint-disable-next-line @typescript-eslint/no-namespace
 export namespace Status {
   /**
    * Converts a HTTP status code into a {@link Status}.