node version

Author: AbhiPrasad

.github/workflows/build.yml

@@ -23,6 +23,7 @@ concurrency:
 
 env:
   HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}
+  CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
   # WARNING: this disables cross os caching as ~ and
   # github.workspace evaluate to differents paths

dev-packages/e2e-tests/Dockerfile.publish-packages

@@ -1,5 +1,5 @@
 # This Dockerfile exists for the purpose of using a specific node/npm version (ie. the same we use in CI) to run npm publish with
-ARG NODE_VERSION=18.17.1
+ARG NODE_VERSION=18.18.0
 FROM node:${NODE_VERSION}
 
 WORKDIR /sentry-javascript/dev-packages/e2e-tests

dev-packages/e2e-tests/package.json

@@ -26,7 +26,7 @@
     "esbuild": "0.20.0"
   },
   "volta": {
-    "node": "18.17.1",
+    "node": "18.18.0",
     "yarn": "1.22.19"
   }
 }

dev-packages/rollup-utils/npmHelpers.mjs

@@ -124,9 +124,6 @@ export function makeBaseNPMConfig(options = {}) {
 }
 
 export function makeNPMConfigVariants(baseConfig) {
-  baseConfig.plugins = baseConfig.plugins || [];
-  baseConfig.plugins.push()
-
   const variantSpecificConfigs = [
     { output: { format: 'cjs', dir: path.join(baseConfig.output.dir, 'cjs') } },
     { output: { format: 'esm', dir: path.join(baseConfig.output.dir, 'esm') } },

dev-packages/rollup-utils/plugins/npmPlugins.mjs

@@ -136,12 +136,11 @@ export function makeRrwebBuildPlugin({ excludeShadowDom, excludeIframe } = {}) {
  * Plugin that uploads bundle analysis to codecov.
  */
 export function makeCodeCovPlugin(bundleName) {
-  console.log(process.env.GITHUB_ACTIONS, process.env.CODECOV_TOKEN === undefined)
   return codecovRollupPlugin({
     enableBundleAnalysis: process.env.GITHUB_ACTIONS === 'true' && process.env.CODECOV_TOKEN,
     bundleName,
     uploadToken: process.env.CODECOV_TOKEN,
-  })
+  });
 }
 
 export { makeExtractPolyfillsPlugin } from './extractPolyfillsPlugin.mjs';

package.json

@@ -41,7 +41,7 @@
     "yalc:publish": "lerna run yalc:publish"
   },
   "volta": {
-    "node": "18.17.0",
+    "node": "18.18.0",
     "yarn": "1.22.19"
   },
   "workspaces": [