fix(browser): Set : as a part of gecko protocol regex group.

Author: onurtemizkan

packages/browser/src/tracekit.ts

@@ -46,7 +46,7 @@ const chrome = /^\s*at (?:(.*?) ?\()?((?:file|https?|blob|chrome-extension|addre
 // gecko regex: `(?:bundle|\d+\.js)`: `bundle` is for react native, `\d+\.js` also but specifically for ram bundles because it
 // generates filenames without a prefix like `file://` the filenames in the stacktrace are just 42.js
 // We need this specific case for now because we want no other regex to match.
-const gecko = /^\s*(.*?)(?:\((.*?)\))?(?:^|@)?((?:file|https?|blob|chrome|webpack|resource|moz-extension|capacitor).*?:\/.*?|\[native code\]|[^@]*(?:bundle|\d+\.js)|\/[\w\-. /=]+)(?::(\d+))?(?::(\d+))?\s*$/i;
+const gecko = /^\s*(.*?)(?:\((.*?)\))?(?:^|@)?((?:file|https?|blob|chrome|webpack|resource|moz-extension|safari-extension|safari-web-extension|capacitor)?:\/.*?|\[native code\]|[^@]*(?:bundle|\d+\.js)|\/[\w\-. /=]+)(?::(\d+))?(?::(\d+))?\s*$/i;
 const winjs = /^\s*at (?:((?:\[object object\])?.+) )?\(?((?:file|ms-appx|https?|webpack|blob):.*?):(\d+)(?::(\d+))?\)?\s*$/i;
 const geckoEval = /(\S+) line (\d+)(?: > eval line \d+)* > eval/i;
 const chromeEval = /\((\S*)(?::(\d+))(?::(\d+))\)/;

packages/browser/test/unit/tracekit/original.test.ts

@@ -15,6 +15,7 @@ import {
   FIREFOX_43_EVAL,
   FIREFOX_44_NS_EXCEPTION,
   FIREFOX_50_RESOURCE_URL,
+  FIREFOX_FILE_IDENTIFIER,
   IE_10,
   IE_11,
   IE_11_EVAL,
@@ -869,6 +870,19 @@ describe('Tracekit - Original Tests', () => {
     });
   });
 
+  it('should parse Firefox errors with `file` inside an identifier', () => {
+    const stackFrames = computeStackTrace(FIREFOX_FILE_IDENTIFIER);
+    expect(stackFrames).toBeTruthy();
+    expect(stackFrames.stack.length).toBe(3);
+    expect(stackFrames.stack[2]).toEqual({
+      args: [],
+      column: 1018410,
+      func: 'handleProfileResult',
+      line: 146,
+      url: 'https://www.random_website.com/main.4a4119c3cdfd10266d84.js',
+    });
+  });
+
   it('should parse React Native errors on Android', () => {
     const stackFrames = computeStackTrace(ANDROID_REACT_NATIVE);
     expect(stackFrames).toBeTruthy();

packages/browser/test/unit/tracekit/originalfixtures.ts

@@ -306,6 +306,18 @@ export const FIREFOX_50_RESOURCE_URL = {
   name: 'TypeError',
 };
 
+export const FIREFOX_FILE_IDENTIFIER = {
+  stack:
+    'us@https://www.random_website.com/vendor.d1cae9cfc9917df88de7.js:1:296021\n' +
+    'detectChanges@https://www.random_website.com/vendor.d1cae9cfc9917df88de7.js:1:333807\n' +
+    'handleProfileResult@https://www.random_website.com/main.4a4119c3cdfd10266d84.js:146:1018410\n',
+  fileName: 'resource://path/data/content/bundle.js',
+  lineNumber: 5529,
+  columnNumber: 16,
+  message: 'this.props.raw[this.state.dataSource].rows is undefined',
+  name: 'TypeError',
+};
+
 export const SAFARI_6 = {
   name: 'foo',
   message: "'null' is not an object (evaluating 'x.undef')",