feat(v8/core): Remove span.attributes top level field (#11378)

ref #10100

Author: AbhiPrasad

packages/core/src/tracing/sentrySpan.ts

@@ -88,22 +88,6 @@ export class SentrySpan implements Span {
   // This rule conflicts with another eslint rule :(
   /* eslint-disable @typescript-eslint/member-ordering */
 
-  /**
-   * Attributes for the span.
-   * @deprecated Use `spanToJSON(span).atttributes` instead.
-   */
-  public get attributes(): SpanAttributes {
-    return this._attributes;
-  }
-
-  /**
-   * Attributes for the span.
-   * @deprecated Use `setAttributes()` instead.
-   */
-  public set attributes(attributes: SpanAttributes) {
-    this._attributes = attributes;
-  }
-
   /**
    * Timestamp in seconds (epoch time) indicating when the span started.
    * @deprecated Use `spanToJSON()` instead.

packages/core/src/tracing/trace.ts

@@ -301,11 +301,12 @@ function _startTransaction(transactionContext: TransactionArguments): Transactio
   const client = getClient();
   const options: Partial<ClientOptions> = (client && client.getOptions()) || {};
 
+  const { name, parentSampled, attributes } = transactionContext;
   const [sampled, sampleRate] = sampleSpan(options, {
-    name: transactionContext.name,
-    parentSampled: transactionContext.parentSampled,
+    name,
+    parentSampled,
+    attributes,
     transactionContext,
-    attributes: transactionContext.attributes,
   });
 
   // eslint-disable-next-line deprecation/deprecation

packages/core/test/lib/tracing/transaction.test.ts

@@ -57,7 +57,7 @@ describe('transaction', () => {
         request: {},
       });
 
-      expect(transaction.attributes).toEqual({
+      expect(spanToJSON(transaction).data).toEqual({
         [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'manual',
         [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url',
         [SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE]: 0.5,

packages/tracing-internal/src/browser/metrics/index.ts

@@ -110,7 +110,7 @@ export function startTrackingInteractions(): void {
         const startTime = msToSec((browserPerformanceTimeOrigin as number) + entry.startTime);
         const duration = msToSec(entry.duration);
 
-        const spanOptions: StartSpanOptions = {
+        const spanOptions: StartSpanOptions & Required<Pick<StartSpanOptions, 'attributes'>> = {
           name: htmlTreeAsString(entry.target),
           op: `ui.interaction.${entry.name}`,
           startTime: startTime,
@@ -121,7 +121,7 @@ export function startTrackingInteractions(): void {
 
         const componentName = getComponentName(entry.target);
         if (componentName) {
-          spanOptions.attributes = { 'ui.component_name': componentName };
+          spanOptions.attributes['ui.component_name'] = componentName;
         }
 
         const span = startInactiveSpan(spanOptions);

packages/types/src/transaction.ts

@@ -3,7 +3,7 @@ import type { DynamicSamplingContext } from './envelope';
 import type { MeasurementUnit } from './measurement';
 import type { ExtractedNodeRequestData, WorkerLocation } from './misc';
 import type { PolymorphicRequest } from './polymorphics';
-import type { SentrySpanArguments, Span, SpanAttributes } from './span';
+import type { SentrySpanArguments, Span } from './span';
 
 /**
  * Interface holding Transaction-specific properties
@@ -63,12 +63,6 @@ export interface Transaction extends Omit<TransactionArguments, 'name' | 'op' |
    */
   startTimestamp: number;
 
-  /**
-   * Attributes for the transaction.
-   * @deprecated Use `getSpanAttributes(transaction)` instead.
-   */
-  attributes: SpanAttributes;
-
   /**
    * Metadata about the transaction.
    * @deprecated Use attributes or store data on the scope instead.