random cleanup

Author: lobsterkatie

packages/ember/addon/instance-initializers/sentry-performance.ts

@@ -28,7 +28,7 @@ export function initialize(appInstance: ApplicationInstance): void {
   }
 }
 
-function getTransitionInformation(transition: any, router: any) {
+function getTransitionInformation(transition: any, router: any): { [key: string]: any } {
   const fromRoute = transition?.from?.name;
   const toRoute = transition && transition.to ? transition.to.name : router.currentRouteName;
   return {

packages/tracing/src/transaction.ts

@@ -6,7 +6,7 @@ import {
   TransactionContext,
   TransactionMetadata,
 } from '@sentry/types';
-import { dropUndefinedKeys, isInstanceOf, logger } from '@sentry/utils';
+import { dropUndefinedKeys, logger } from '@sentry/utils';
 
 import { Span as SpanClass, SpanRecorder } from './span';
 
@@ -21,7 +21,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
   /**
    * The reference to the current hub.
    */
-  private readonly _hub: Hub = (getCurrentHub() as unknown) as Hub;
+  private readonly _hub: Hub;
 
   private _trimEnd?: boolean;
 
@@ -35,16 +35,14 @@ export class Transaction extends SpanClass implements TransactionInterface {
   public constructor(transactionContext: TransactionContext, hub?: Hub) {
     super(transactionContext);
 
-    if (isInstanceOf(hub, Hub)) {
-      this._hub = hub as Hub;
-    }
-
     this.name = transactionContext.name || '';
-
     this.metadata = transactionContext.metadata || {};
     this._trimEnd = transactionContext.trimEnd;
+    this._hub = hub || getCurrentHub();
 
-    // this is because transactions are also spans, and spans have a transaction pointer
+    // this is because transactions are also spans, and spans have a transaction pointer (it doesn't get set in `super`
+    // because theoretically you can create a span without a transaction, though at the moment it doesn't do you much
+    // good)
     this.transaction = this;
   }
 

packages/utils/src/misc.ts

@@ -217,6 +217,7 @@ interface SemVer {
 /**
  * Parses input into a SemVer interface
  * @param input string representation of a semver version
+ * @returns A object containing each part of the version string as a separate entry
  */
 export function parseSemver(input: string): SemVer {
   const match = input.match(SEMVER_REGEXP) || [];