ref: Minor changes related to bundle size

Author: kamilogorek

packages/core/src/dsn.ts

@@ -4,6 +4,9 @@ import { SentryError } from '@sentry/utils/error';
 /** Regular expression used to parse a Dsn. */
 const DSN_REGEX = /^(?:(\w+):)\/\/(?:(\w+)(?::(\w+))?@)([\w\.-]+)(?::(\d+))?\/(.+)/;
 
+/** Error message */
+const ERROR_MESSAGE = 'Invalid Dsn';
+
 /** The Sentry Dsn, identifying a Sentry instance and project. */
 export class Dsn implements DsnComponents {
   /** Protocol used to connect to Sentry. */
@@ -54,7 +57,7 @@ export class Dsn implements DsnComponents {
   private fromString(str: string): void {
     const match = DSN_REGEX.exec(str);
     if (!match) {
-      throw new SentryError('Invalid Dsn');
+      throw new SentryError(ERROR_MESSAGE);
     }
 
     const [protocol, user, pass = '', host, port = '', lastPath] = match.slice(1);
@@ -81,18 +84,18 @@ export class Dsn implements DsnComponents {
 
   /** Validates this Dsn and throws on error. */
   private validate(): void {
-    for (const component of ['protocol', 'user', 'host', 'projectId']) {
+    ['protocol', 'user', 'host', 'projectId'].forEach(component => {
       if (!this[component as keyof DsnComponents]) {
-        throw new SentryError(`Invalid Dsn: Missing ${component}`);
+        throw new SentryError(ERROR_MESSAGE);
       }
-    }
+    });
 
     if (this.protocol !== 'http' && this.protocol !== 'https') {
-      throw new SentryError(`Invalid Dsn: Unsupported protocol "${this.protocol}"`);
+      throw new SentryError(ERROR_MESSAGE);
     }
 
     if (this.port && Number.isNaN(parseInt(this.port, 10))) {
-      throw new SentryError(`Invalid Dsn: Invalid port number "${this.port}"`);
+      throw new SentryError(ERROR_MESSAGE);
     }
   }
 }

packages/core/src/integration.ts

@@ -15,26 +15,26 @@ export function getIntegrationsToSetup(options: Options): Integration[] {
   let integrations: Integration[] = [];
   if (Array.isArray(userIntegrations)) {
     const userIntegrationsNames = userIntegrations.map(i => i.name);
-    const pickedIntegrationsNames = [];
+    const pickedIntegrationsNames: string[] = [];
 
     // Leave only unique default integrations, that were not overridden with provided user integrations
-    for (const defaultIntegration of defaultIntegrations) {
+    defaultIntegrations.forEach(defaultIntegration => {
       if (
         userIntegrationsNames.indexOf(getIntegrationName(defaultIntegration)) === -1 &&
         pickedIntegrationsNames.indexOf(getIntegrationName(defaultIntegration)) === -1
       ) {
         integrations.push(defaultIntegration);
         pickedIntegrationsNames.push(getIntegrationName(defaultIntegration));
       }
-    }
+    });
 
     // Don't add same user integration twice
-    for (const userIntegration of userIntegrations) {
+    userIntegrations.forEach(userIntegration => {
       if (pickedIntegrationsNames.indexOf(getIntegrationName(userIntegration)) === -1) {
         integrations.push(userIntegration);
         pickedIntegrationsNames.push(getIntegrationName(userIntegration));
       }
-    }
+    });
   } else if (typeof userIntegrations === 'function') {
     integrations = userIntegrations(defaultIntegrations);
     integrations = Array.isArray(integrations) ? integrations : [integrations];

packages/utils/src/fs.ts

@@ -1,28 +1,8 @@
-import { mkdir, mkdirSync, readFile, statSync } from 'fs';
+import { mkdir, mkdirSync, statSync } from 'fs';
 import { dirname, resolve } from 'path';
 
 const _0777 = parseInt('0777', 8);
 
-/**
- * Asynchronously reads given files content.
- *
- * @param path A relative or absolute path to the file
- * @returns A Promise that resolves when the file has been read.
- */
-export async function readFileAsync(path: string): Promise<string> {
-  // We cannot use util.promisify here because that was only introduced in Node
-  // 8 and we need to support older Node versions.
-  return new Promise<string>((res, reject) => {
-    readFile(path, 'utf8', (err, data) => {
-      if (err) {
-        reject(err);
-      } else {
-        res(data);
-      }
-    });
-  });
-}
-
 /**
  * Asynchronously creates the given directory.
  *

packages/utils/src/logger.ts

@@ -3,6 +3,9 @@ import { consoleSandbox, getGlobalObject } from './misc';
 // TODO: Implement different loggers for different environments
 const global = getGlobalObject() as Window;
 
+/** Prefix for logging strings */
+const PREFIX = 'Sentry Logger ';
+
 /** JSDoc */
 class Logger {
   /** JSDoc */
@@ -29,7 +32,7 @@ class Logger {
       return;
     }
     consoleSandbox(() => {
-      global.console.log(`Sentry Logger [Log]: ${args.join(' ')}`); // tslint:disable-line:no-console
+      global.console.log(`${PREFIX}[Log]: ${args.join(' ')}`); // tslint:disable-line:no-console
     });
   }
 
@@ -39,7 +42,7 @@ class Logger {
       return;
     }
     consoleSandbox(() => {
-      global.console.warn(`Sentry Logger [Warn]: ${args.join(' ')}`); // tslint:disable-line:no-console
+      global.console.warn(`${PREFIX}[Warn]: ${args.join(' ')}`); // tslint:disable-line:no-console
     });
   }
 
@@ -49,7 +52,7 @@ class Logger {
       return;
     }
     consoleSandbox(() => {
-      global.console.error(`Sentry Logger [Error]: ${args.join(' ')}`); // tslint:disable-line:no-console
+      global.console.error(`${PREFIX}[Error]: ${args.join(' ')}`); // tslint:disable-line:no-console
     });
   }
 }

packages/utils/src/supports.ts

@@ -131,7 +131,7 @@ export function supportsReferrerPolicy(): boolean {
 
   try {
     // tslint:disable:no-unused-expression
-    new Request('pickleRick', {
+    new Request('_', {
       referrerPolicy: 'origin' as ReferrerPolicy,
     });
     return true;