Skip to content

Commit db8fa1a

Browse files
committed
resolve with warning rather than reject if client is undefined
1 parent 050a486 commit db8fa1a

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

packages/browser/src/sdk.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@ export function flush(timeout?: number): PromiseLike<boolean> {
156156
if (client) {
157157
return client.flush(timeout);
158158
}
159-
return SyncPromise.reject(false);
159+
logger.warn('Cannot flush events. No client defined.');
160+
return SyncPromise.resolve(false);
160161
}
161162

162163
/**
@@ -170,7 +171,8 @@ export function close(timeout?: number): PromiseLike<boolean> {
170171
if (client) {
171172
return client.close(timeout);
172173
}
173-
return SyncPromise.reject(false);
174+
logger.warn('Cannot flush events and disable SDK. No client defined.');
175+
return SyncPromise.resolve(false);
174176
}
175177

176178
/**

packages/node/src/sdk.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { getCurrentHub, initAndBind, Integrations as CoreIntegrations } from '@sentry/core';
22
import { getMainCarrier, setHubOnCarrier } from '@sentry/hub';
33
import { SessionStatus } from '@sentry/types';
4-
import { getGlobalObject } from '@sentry/utils';
4+
import { getGlobalObject, logger } from '@sentry/utils';
55
import * as domain from 'domain';
66

77
import { NodeClient } from './client';
@@ -150,7 +150,8 @@ export async function flush(timeout?: number): Promise<boolean> {
150150
if (client) {
151151
return client.flush(timeout);
152152
}
153-
return Promise.reject(false);
153+
logger.warn('Cannot flush events. No client defined.');
154+
return Promise.resolve(false);
154155
}
155156

156157
/**
@@ -164,7 +165,8 @@ export async function close(timeout?: number): Promise<boolean> {
164165
if (client) {
165166
return client.close(timeout);
166167
}
167-
return Promise.reject(false);
168+
logger.warn('Cannot flush events and disable SDK. No client defined.');
169+
return Promise.resolve(false);
168170
}
169171

170172
/**

0 commit comments

Comments
 (0)