s/makeMinificationVariants/makeConfigVariants, s/newConfigs/configVariants, s/bundleVariants/variantSpecificOptionsVariants

Author: lobsterkatie

packages/browser/rollup.config.js

@@ -1,4 +1,4 @@
-import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';
+import { makeBaseBundleConfig, makeConfigVariants } from '../../rollup.config';
 
 const builds = [];
 
@@ -11,7 +11,7 @@ const builds = [];
     outputFileBase: `build/bundle${jsVersion === 'es6' ? '.es6' : ''}`,
   });
 
-  builds.push(...makeMinificationVariants(baseBundleConfig));
+  builds.push(...makeConfigVariants(baseBundleConfig));
 });
 
 export default builds;

packages/integrations/rollup.config.js

@@ -2,7 +2,7 @@ import * as fs from 'fs';
 
 import commonjs from '@rollup/plugin-commonjs';
 
-import { insertAt, makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';
+import { insertAt, makeBaseBundleConfig, makeConfigVariants } from '../../rollup.config';
 
 const builds = [];
 
@@ -20,7 +20,7 @@ integrationSourceFiles.forEach(file => {
   // TODO We only need `commonjs` for localforage (used in the offline plugin). Once that's fixed, this can come out.
   baseBundleConfig.plugins = insertAt(baseBundleConfig.plugins, -2, commonjs());
 
-  builds.push(...makeMinificationVariants(baseBundleConfig));
+  builds.push(...makeConfigVariants(baseBundleConfig));
 });
 
 export default builds;

packages/tracing/rollup.config.js

@@ -1,4 +1,4 @@
-import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';
+import { makeBaseBundleConfig, makeConfigVariants } from '../../rollup.config';
 
 const builds = [];
 
@@ -11,7 +11,7 @@ const builds = [];
     outputFileBase: `build/bundle.tracing${jsVersion === 'es6' ? '.es6' : ''}`,
   });
 
-  builds.push(...makeMinificationVariants(baseBundleConfig));
+  builds.push(...makeConfigVariants(baseBundleConfig));
 });
 
 export default builds;

packages/vue/rollup.config.js

@@ -1,4 +1,4 @@
-import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';
+import { makeBaseBundleConfig, makeConfigVariants } from '../../rollup.config';
 
 const baseBundleConfig = makeBaseBundleConfig({
   input: 'src/index.bundle.ts',
@@ -8,4 +8,4 @@ const baseBundleConfig = makeBaseBundleConfig({
   outputFileBase: 'build/bundle.vue',
 });
 
-export default makeMinificationVariants(baseBundleConfig);
+export default makeConfigVariants(baseBundleConfig);

packages/wasm/rollup.config.js

@@ -1,4 +1,4 @@
-import { makeBaseBundleConfig, makeMinificationVariants } from '../../rollup.config';
+import { makeBaseBundleConfig, makeConfigVariants } from '../../rollup.config';
 
 const baseBundleConfig = makeBaseBundleConfig({
   input: 'src/index.ts',
@@ -8,4 +8,4 @@ const baseBundleConfig = makeBaseBundleConfig({
   outputFileBase: 'build/wasm',
 });
 
-export default makeMinificationVariants(baseBundleConfig);
+export default makeConfigVariants(baseBundleConfig);

rollup.config.js

@@ -190,8 +190,14 @@ export function makeBaseBundleConfig(options) {
   return deepMerge(sharedBundleConfig, isAddOn ? addOnBundleConfig : standAloneBundleConfig);
 }
 
-export function makeMinificationVariants(baseConfig) {
-  const newConfigs = [];
+/**
+ * Takes the CDN rollup config for a given package and produces configs for both minified and unminified bundles.
+ *
+ * @param baseConfig The rollup config shared by the entire package
+ * @returns An array of versions of that config
+ */
+export function makeConfigVariants(baseConfig) {
+  const configVariants = [];
 
   const { plugins } = baseConfig;
 
@@ -201,7 +207,8 @@ export function makeMinificationVariants(baseConfig) {
     `Last plugin in given options should be \`rollup-plugin-license\`. Found ${getLastElement(plugins).name}`,
   );
 
-  const bundleVariants = [
+  // The additional options to use for each variant we're going to create #namingishard
+  const variantSpecificOptionsVariants = [
     {
       output: {
         file: `${baseConfig.output.file}.js`,
@@ -216,14 +223,14 @@ export function makeMinificationVariants(baseConfig) {
     },
   ];
 
-  bundleVariants.forEach(variant => {
+  variantSpecificOptionsVariants.forEach(variant => {
     const mergedConfig = deepMerge(baseConfig, variant, {
       // this makes it so that instead of concatenating the `plugin` properties of the two objects, the first value is
       // just overwritten by the second value
       arrayMerge: (first, second) => second,
     });
-    newConfigs.push(mergedConfig);
+    configVariants.push(mergedConfig);
   });
 
-  return newConfigs;
+  return configVariants;
 }