ref(profiling): unref timer

Author: JonasBa

packages/profiling-node/bindings/cpu_profiler.cc

@@ -76,7 +76,8 @@ class MeasurementsTicker {
   MeasurementsTicker(uv_loop_t *loop)
       : period_ms(100), isolate(v8::Isolate::GetCurrent()) {
     uv_timer_init(loop, &timer);
-    timer.data = this;
+    uv_handle_set_data(&timer, this);
+    uv_unref(reinterpret_cast<uv_handle_t *>(&timer));
   }
 
   static void ticker(uv_timer_t *);
@@ -196,6 +197,10 @@ void MeasurementsTicker::cpu_callback() {
 };
 
 void MeasurementsTicker::ticker(uv_timer_t *handle) {
+  if(handle == nullptr) {
+    return;
+  }
+
   MeasurementsTicker *self = static_cast<MeasurementsTicker *>(handle->data);
   self->heap_callback();
   self->cpu_callback();
@@ -231,6 +236,19 @@ class Profiler {
       : measurements_ticker(uv_default_loop()),
         cpu_profiler(
             v8::CpuProfiler::New(isolate, kNamingMode, GetLoggingMode())) {}
+
+  ~Profiler() {
+    for (auto &profile : active_profiles) {
+      CleanupSentryProfile(this, profile.second, profile.first);
+    }
+
+    active_profiles.clear();
+
+    if (cpu_profiler) {
+      cpu_profiler->Dispose();
+      cpu_profiler = nullptr;
+    }
+  }
 };
 
 class SentryProfile {
@@ -1041,16 +1059,6 @@ void FreeAddonData(napi_env env, void *data, void *hint) {
     return;
   }
 
-  if (!profiler->active_profiles.empty()) {
-    for (auto &profile : profiler->active_profiles) {
-      CleanupSentryProfile(profiler, profile.second, profile.first);
-    }
-  }
-
-  if (profiler->cpu_profiler != nullptr) {
-    profiler->cpu_profiler->Dispose();
-  }
-
   delete profiler;
 }