move NoopTransport test to Core Client tests

Author: Lms24

packages/browser/src/client.ts

@@ -14,7 +14,7 @@ import { FetchTransport, makeNewFetchTransport, makeNewXHRTransport, XHRTranspor
  *
  * @see BrowserOptions for documentation on configuration options.
  * @see SentryClient for usage documentation.
- * TODO: remove BrowserBackend
+ * TODO(v7): remove BrowserBackend
  */
 export class BrowserClient extends BaseClient<BrowserBackend, BrowserOptions> {
   /**
@@ -35,7 +35,7 @@ export class BrowserClient extends BaseClient<BrowserBackend, BrowserOptions> {
       version: SDK_VERSION,
     };
 
-    // TODO: remove BrowserBackend param
+    // TODO(v7): remove BrowserBackend param
     super(BrowserBackend, options);
   }
 

packages/browser/test/unit/backend.test.ts

@@ -2,6 +2,8 @@ import { BrowserBackend } from '../../src/backend';
 
 let backend: BrowserBackend;
 
+// TODO(v7): remove when deleting Backend
+
 describe('BrowserBackend', () => {
   describe('sendEvent()', () => {
     it('should use NoopTransport', () => {

packages/core/src/baseclient.ts

@@ -41,7 +41,7 @@ const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been ca
 /**
  * Base implementation for all JavaScript SDK clients.
  *
- * TODO: refactor doc w.r.t. Backend
+ * TODO(v7): refactor doc w.r.t. Backend
  *
  * Call the constructor with the corresponding backend constructor and options
  * specific to the client subclass. To access these options later, use
@@ -77,7 +77,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
    * The backend used to physically interact in the environment. Usually, this
    * will correspond to the client. When composing SDKs, however, the Backend
    * from the root SDK will be used.
-   * TODO: DELETE
+   * TODO(v7): DELETE
    */
   protected readonly _backend: B;
 
@@ -106,7 +106,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
    * @param options Options for the client.
    */
   protected constructor(backendClass: BackendClass<B, O>, options: O) {
-    // TODO: Delete
+    // TODO(v7): Delete
     this._backend = new backendClass(options);
     this._options = options;
 
@@ -149,7 +149,6 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
   public captureMessage(message: string, level?: Severity, hint?: EventHint, scope?: Scope): string | undefined {
     let eventId: string | undefined = hint && hint.event_id;
 
-    // TODO: refactor
     const promisedEvent = isPrimitive(message)
       ? this.eventFromMessage(String(message), level, hint)
       : this.eventFromException(message, hint);
@@ -367,6 +366,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
   }
 
   /** Deliver captured session to Sentry */
+  // TODO(v7): should this be deleted?
   protected _sendSession(session: Session): void {
     this.sendSession(session);
   }
@@ -402,7 +402,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
   }
 
   /** Returns the current backend.
-   * TODO: DELETE
+   * TODO(v7): DELETE
    */
   protected _getBackend(): B {
     return this._backend;
@@ -576,7 +576,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
    * Tells the backend to send this event
    * @param event The Sentry event to send
    */
-  // TODO: refactor: get rid of method?
+  // TODO(v7): refactor: get rid of method?
   protected _sendEvent(event: Event): void {
     this.sendEvent(event);
   }

packages/core/test/lib/base.test.ts

@@ -3,6 +3,7 @@ import { Event, Span, Transport } from '@sentry/types';
 import { dsnToString, logger, SentryError, SyncPromise } from '@sentry/utils';
 
 import * as integrationModule from '../../src/integration';
+import { NoopTransport } from '../../src/transports/noop';
 import { TestBackend } from '../mocks/backend';
 import { TestClient } from '../mocks/client';
 import { TestIntegration } from '../mocks/integration';
@@ -107,6 +108,16 @@ describe('BaseClient', () => {
       expect(client.getTransport()).toBeInstanceOf(FakeTransport);
       expect(TestClient.instance!.getTransport()).toBe(client.getTransport());
     });
+
+    test('retruns NoopTransport when no transport is passed', () => {
+      expect.assertions(2);
+
+      const options = { dsn: PUBLIC_DSN };
+      const client = new TestClient(options);
+
+      expect(client.getTransport()).toBeInstanceOf(NoopTransport);
+      expect(TestClient.instance!.getTransport()).toBe(client.getTransport());
+    });
   });
 
   describe('getBreadcrumbs() / addBreadcrumb()', () => {

packages/core/test/mocks/client.ts

@@ -10,7 +10,7 @@ export interface TestOptions extends Options {
   enableSend?: boolean;
 }
 
-// TODO: remove TestBackend
+// TODO(v7): remove TestBackend
 export class TestClient extends BaseClient<TestBackend, TestOptions> {
   public static instance?: TestClient;
   public static sendEventCalled?: (event: Event) => void;
@@ -19,7 +19,7 @@ export class TestClient extends BaseClient<TestBackend, TestOptions> {
   public session?: Session;
 
   public constructor(options: TestOptions) {
-    // TODO: remove TestBackend param
+    // TODO(v7): remove TestBackend param
     super(TestBackend, options);
     TestClient.instance = this;
   }

packages/ember/package.json

@@ -64,7 +64,7 @@
     "ember-qunit": "~4.6.0",
     "ember-resolver": "~8.0.0",
     "ember-sinon-qunit": "~5.0.0",
-    "ember-source": "~3.20.0",
+    "ember-source": "https://s3.amazonaws.com/builds.emberjs.com/release/shas/e75bc645f3d3472e69515cd12e38e5f7f0fce5e9.tgz",
     "ember-source-channel-url": "~2.0.1",
     "ember-template-lint": "~2.9.1",
     "ember-test-selectors": "~5.5.0",
@@ -89,4 +89,4 @@
     "node": "14.15.4",
     "yarn": "1.22.5"
   }
-}
+}

packages/node/src/client.ts

@@ -15,7 +15,7 @@ import { NodeOptions } from './types';
  * @see NodeOptions for documentation on configuration options.
  * @see SentryClient for usage documentation.
  *
- * TODO: remove NodeBackend
+ * TODO(v7): remove NodeBackend
  */
 export class NodeClient extends BaseClient<NodeBackend, NodeOptions> {
   protected _sessionFlusher: SessionFlusher | undefined;
@@ -37,7 +37,7 @@ export class NodeClient extends BaseClient<NodeBackend, NodeOptions> {
       version: SDK_VERSION,
     };
 
-    // TODO: remove NodeBackend param
+    // TODO(v7): remove NodeBackend param
     super(NodeBackend, options);
   }