update tests

Author: billyvg

dev-packages/browser-integration-tests/suites/replay/canvas/records/init.js

@@ -1,16 +1,10 @@
-import { getCanvasManager } from '@sentry-internal/rrweb';
 import * as Sentry from '@sentry/browser';
 
 window.Sentry = Sentry;
 window.Replay = new Sentry.Replay({
   flushMinDelay: 50,
   flushMaxDelay: 50,
   minReplayDuration: 0,
-  _experiments: {
-    canvas: {
-      manager: getCanvasManager,
-    },
-  },
 });
 
 Sentry.init({
@@ -20,5 +14,5 @@ Sentry.init({
   replaysOnErrorSampleRate: 0.0,
   debug: true,
 
-  integrations: [window.Replay],
+  integrations: [window.Replay, new Sentry.ReplayCanvas()],
 });

dev-packages/browser-integration-tests/suites/replay/canvas/withCanvasIntegrationFirst/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import type { ReplayCanvasIntegrationOptions } from '@sentry-internal/replay-canvas';
 
 import { sentryTest } from '../../../../utils/fixtures';
 import { getReplaySnapshot, shouldSkipReplayTest } from '../../../../utils/replayHelpers';
@@ -21,8 +22,8 @@ sentryTest('sets up canvas when adding ReplayCanvas integration first', async ({
   await page.goto(url);
 
   const replay = await getReplaySnapshot(page);
-  const canvasOptions = replay._options._experiments?.canvas;
-  expect(canvasOptions.fps).toBe(4);
-  expect(canvasOptions.quality).toBe(0.6);
+  const canvasOptions = replay._integrations.canvas as ReplayCanvasIntegrationOptions;
+  expect(canvasOptions.sampling.canvas).toBe(2);
+  expect(canvasOptions.dataURLOptions.quality).toBe(0.4);
   expect(replay._hasCanvas).toBe(true);
 });

dev-packages/browser-integration-tests/suites/replay/canvas/withCanvasIntegrationSecond/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import type { ReplayCanvasIntegrationOptions } from '@sentry-internal/replay-canvas';
 
 import { sentryTest } from '../../../../utils/fixtures';
 import { getReplaySnapshot, shouldSkipReplayTest } from '../../../../utils/replayHelpers';
@@ -21,8 +22,8 @@ sentryTest('sets up canvas when adding ReplayCanvas integration after Replay', a
   await page.goto(url);
 
   const replay = await getReplaySnapshot(page);
-  const canvasOptions = replay._options._experiments?.canvas;
-  expect(canvasOptions.fps).toBe(4);
-  expect(canvasOptions.quality).toBe(0.6);
+  const canvasOptions = replay._integrations.canvas as ReplayCanvasIntegrationOptions;
+  expect(canvasOptions.sampling.canvas).toBe(2);
+  expect(canvasOptions.dataURLOptions.quality).toBe(0.4);
   expect(replay._hasCanvas).toBe(true);
 });

dev-packages/browser-integration-tests/suites/replay/canvas/withoutCanvasIntegration/test.ts

@@ -21,7 +21,7 @@ sentryTest('does not setup up canvas without ReplayCanvas integration', async ({
   await page.goto(url);
 
   const replay = await getReplaySnapshot(page);
-  const canvasOptions = replay._options._experiments?.canvas;
+  const canvasOptions = replay._integrations.canvas;
   expect(canvasOptions).toBe(undefined);
   expect(replay._hasCanvas).toBe(false);
 });

dev-packages/browser-integration-tests/utils/replayHelpers.ts

@@ -174,6 +174,7 @@ export function getReplaySnapshot(page: Page): Promise<{
   _isEnabled: boolean;
   _context: InternalEventContext;
   _options: ReplayPluginOptions;
+  _integrations: Record<string, unknown>;
   _hasCanvas: boolean;
   session: Session | undefined;
   recordingMode: ReplayRecordingMode;
@@ -187,8 +188,9 @@ export function getReplaySnapshot(page: Page): Promise<{
       _isEnabled: replay.isEnabled(),
       _context: replay.getContext(),
       _options: replay.getOptions(),
+      _integrations: replay.getIntegrations(),
       // We cannot pass the function through as this is serialized
-      _hasCanvas: typeof replay.getOptions()._experiments.canvas?.manager === 'function',
+      _hasCanvas: typeof replay.getIntegrations().canvas?.getCanvasManager === 'function',
       session: replay.session,
       recordingMode: replay.recordingMode,
     };

packages/replay-canvas/src/canvas.ts

@@ -6,7 +6,7 @@ interface ReplayCanvasOptions {
   quality: 'low' | 'medium' | 'high';
 }
 
-interface ReplayCanvasIntegrationOptions {
+export interface ReplayCanvasIntegrationOptions {
   recordCanvas: true;
   getCanvasManager: (options: ConstructorParameters<typeof CanvasManager>[0]) => CanvasManagerInterface;
   sampling: {

packages/replay-canvas/src/index.ts

@@ -1 +1,2 @@
 export { ReplayCanvas } from './canvas';
+export type { ReplayCanvasIntegrationOptions } from './canvas';

packages/replay/src/replay.ts

@@ -228,6 +228,11 @@ export class ReplayContainer implements ReplayContainerInterface {
     return this._options;
   }
 
+  /** Get the replay integrations. [test only] */
+  public getIntegrations(): Record<string, Record<string, unknown>> {
+    return { ...this._integrations };
+  }
+
   /**
    * Initializes the plugin based on sampling configuration. Should not be
    * called outside of constructor.

packages/replay/src/types/replay.ts

@@ -14,7 +14,7 @@ import type { SKIPPED, THROTTLED } from '../util/throttle';
 import type { AllPerformanceEntry, AllPerformanceEntryData, ReplayPerformanceEntry } from './performance';
 import type { ReplayFrameEvent } from './replayFrame';
 import type { ReplayNetworkRequestOrResponse } from './request';
-import type { CanvasManagerInterface, GetCanvasManagerOptions, ReplayEventWithTime, RrwebRecordOptions } from './rrweb';
+import type { ReplayEventWithTime, RrwebRecordOptions } from './rrweb';
 
 export type RecordingEvent = ReplayFrameEvent | ReplayEventWithTime;
 export type RecordingOptions = RrwebRecordOptions;
@@ -232,10 +232,6 @@ export interface ReplayPluginOptions extends ReplayNetworkOptions {
   _experiments: Partial<{
     captureExceptions: boolean;
     traceInternals: boolean;
-    canvas: {
-      quality?: 'low' | 'medium' | 'high';
-      manager: (options: GetCanvasManagerOptions) => CanvasManagerInterface;
-    };
   }>;
 }
 
@@ -506,6 +502,7 @@ export interface ReplayContainer {
   updateUserActivity(): void;
   addUpdate(cb: AddUpdateCallback): void;
   getOptions(): ReplayPluginOptions;
+  getIntegrations(): Record<string, Record<string, unknown>>;
   getSessionId(): string | undefined;
   checkAndHandleExpiredSession(): boolean | void;
   setInitialState(): void;