Skip to content

Commit cde925b

Browse files
committed
clean up timing
1 parent f92c512 commit cde925b

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

packages/remix/test/integration/app/routes/scope-bleed/$id.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ import { json, LoaderFunction } from '@remix-run/node';
33
import * as Sentry from '@sentry/remix';
44

55
export const loader: LoaderFunction = async ({ params: { id } }) => {
6+
// Set delay to simulate requests at the same time
67
await new Promise(resolve => setTimeout(resolve, parseInt(id || '', 10) * 1000 - 1000));
78
Sentry.setTag(`tag${id}`, id);
8-
await new Promise(resolve => setTimeout(resolve, 1000));
9-
109
return json({ test: 'test' });
1110
};
1211

packages/remix/test/integration/test/server/loader.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe.each(['builtin', 'express'])('Remix API Loaders with adapter = %s', ada
138138
});
139139

140140
it('makes sure scope does not bleed between requests', async () => {
141-
const baseURL = await runServer();
141+
const baseURL = await runServer(adapter);
142142

143143
await Promise.all(
144144
Array.from(Array(5).keys()).map(async (id: number) => {
145145
const url = `${baseURL}/scope-bleed/${id}`;
146-
await new Promise(resolve => setTimeout(resolve, 5000 - id * 1000 - 1000));
147146
const envelope = await getEnvelopeRequest(url);
148147
const transaction = envelope[2];
149148

0 commit comments

Comments
 (0)