feat: Ensure getRootSpan() does not rely on transaction (#10979)

Instead, we keep the root span as a non-enumerable property on the span.
We use the already existing method for this, so this should work
reasonably well.

This also means that now `getRootSpan` can always return a `Span`, not
`undefined` anymore, which makes types a bit easier there.

Also, we now ensure to export this everywhere.

Author: mydea

dev-packages/browser-integration-tests/suites/manual-client/browser-context/init.js

@@ -29,7 +29,6 @@ const client = new BrowserClient({
   transport: makeFetchTransport,
   stackParser: defaultStackParser,
   integrations,
-  debug: true,
 });
 
 const hub = new Hub(client);

dev-packages/browser-integration-tests/suites/public-api/instrumentation/setTimeoutFrozen/init.js

@@ -4,5 +4,6 @@ window.Sentry = Sentry;
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
+  // We assert on the debug message, so we need to enable debug mode
   debug: true,
 });

dev-packages/browser-integration-tests/suites/public-api/startSpan/basic/test.ts

@@ -1,16 +1,20 @@
 import { expect } from '@playwright/test';
-import type { Event } from '@sentry/types';
 
 import { sentryTest } from '../../../../utils/fixtures';
-import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
+import {
+  envelopeRequestParser,
+  shouldSkipTracingTest,
+  waitForTransactionRequestOnUrl,
+} from '../../../../utils/helpers';
 
 sentryTest('should send a transaction in an envelope', async ({ getLocalTestPath, page }) => {
   if (shouldSkipTracingTest()) {
     sentryTest.skip();
   }
 
   const url = await getLocalTestPath({ testDir: __dirname });
-  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
+  const req = await waitForTransactionRequestOnUrl(page, url);
+  const transaction = envelopeRequestParser(req);
 
   expect(transaction.transaction).toBe('parent_span');
   expect(transaction.spans).toBeDefined();
@@ -22,7 +26,8 @@ sentryTest('should report finished spans as children of the root transaction', a
   }
 
   const url = await getLocalTestPath({ testDir: __dirname });
-  const transaction = await getFirstSentryEnvelopeRequest<Event>(page, url);
+  const req = await waitForTransactionRequestOnUrl(page, url);
+  const transaction = envelopeRequestParser(req);
 
   expect(transaction.spans).toHaveLength(1);
 

dev-packages/browser-integration-tests/suites/public-api/startSpan/init.js

@@ -8,5 +8,4 @@ Sentry.init({
   dsn: 'https://[email protected]/1337',
   tracesSampleRate: 1.0,
   normalizeDepth: 10,
-  debug: true,
 });

dev-packages/browser-integration-tests/suites/replay/canvas/manualSnapshot/init.js

@@ -12,7 +12,6 @@ Sentry.init({
   sampleRate: 0,
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 0.0,
-  debug: true,
 
   integrations: [window.Replay, Sentry.replayCanvasIntegration({ enableManualSnapshot: true })],
 });

dev-packages/browser-integration-tests/suites/replay/canvas/records/init.js

@@ -12,7 +12,6 @@ Sentry.init({
   sampleRate: 0,
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 0.0,
-  debug: true,
 
   integrations: [window.Replay, Sentry.replayCanvasIntegration()],
 });

dev-packages/browser-integration-tests/suites/replay/canvas/withCanvasIntegrationFirst/init.js

@@ -12,7 +12,6 @@ Sentry.init({
   sampleRate: 0,
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 0.0,
-  debug: true,
 
   integrations: [Sentry.replayCanvasIntegration(), window.Replay],
 });

dev-packages/browser-integration-tests/suites/replay/canvas/withCanvasIntegrationSecond/init.js

@@ -12,7 +12,6 @@ Sentry.init({
   sampleRate: 0,
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 0.0,
-  debug: true,
 
   integrations: [window.Replay, Sentry.replayCanvasIntegration()],
 });

dev-packages/browser-integration-tests/suites/replay/canvas/withoutCanvasIntegration/init.js

@@ -12,7 +12,6 @@ Sentry.init({
   sampleRate: 0,
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 0.0,
-  debug: true,
 
   integrations: [window.Replay],
 });

dev-packages/browser-integration-tests/suites/sessions/initial-scope/init.js

@@ -12,5 +12,4 @@ Sentry.init({
       username: 'user1337',
     },
   },
-  debug: true,
 });