test adjustments

Author: mydea

dev-packages/e2e-tests/test-applications/node-express-send-to-sentry/playwright.config.mjs

@@ -1,10 +1,5 @@
 import { devices } from '@playwright/test';
 
-// Fix urls not resolving to localhost on Node v17+
-// See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575
-import { setDefaultResultOrder } from 'dns';
-setDefaultResultOrder('ipv4first');
-
 const expressPort = 3030;
 
 /**

dev-packages/e2e-tests/test-applications/react-create-hash-router/tests/transactions.test.ts

@@ -50,20 +50,6 @@ test('Captures a pageload transaction', async ({ page }) => {
     trace_id: expect.any(String),
     origin: 'auto.ui.browser.metrics',
   });
-  expect(transactionEvent.spans).toContainEqual({
-    data: {
-      'sentry.origin': 'auto.ui.browser.metrics',
-      'sentry.op': 'browser',
-    },
-    description: 'loadEvent',
-    op: 'browser',
-    parent_span_id: expect.any(String),
-    span_id: expect.any(String),
-    start_timestamp: expect.any(Number),
-    timestamp: expect.any(Number),
-    trace_id: expect.any(String),
-    origin: 'auto.ui.browser.metrics',
-  });
   expect(transactionEvent.spans).toContainEqual({
     data: {
       'sentry.origin': 'auto.ui.browser.metrics',

dev-packages/e2e-tests/test-applications/react-send-to-sentry/package.json

@@ -48,7 +48,6 @@
   },
   "devDependencies": {
     "@playwright/test": "^1.44.1",
-    "axios": "1.6.0",
     "serve": "14.0.1"
   },
   "volta": {

dev-packages/e2e-tests/test-applications/react-send-to-sentry/playwright.config.mjs

@@ -0,0 +1,69 @@
+import { devices } from '@playwright/test';
+
+/**
+ * See https://playwright.dev/docs/test-configuration.
+ */
+const config = {
+  testDir: './tests',
+  /* Maximum time one test can run for. */
+  timeout: 150_000,
+  expect: {
+    /**
+     * Maximum time expect() should wait for the condition to be met.
+     * For example in `await expect(locator).toHaveText();`
+     */
+    timeout: 5000,
+  },
+  /* Run tests in files in parallel */
+  fullyParallel: true,
+  /* Fail the build on CI if you accidentally left test.only in the source code. */
+  forbidOnly: !!process.env.CI,
+  /* Retry on CI only */
+  retries: 0,
+  /* Opt out of parallel tests on CI. */
+  workers: 1,
+  /* Reporter to use. See https://playwright.dev/docs/test-reporters */
+  reporter: 'list',
+  /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
+  use: {
+    /* Maximum time each action such as `click()` can take. Defaults to 0 (no limit). */
+    actionTimeout: 0,
+
+    /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
+    trace: 'on-first-retry',
+  },
+
+  /* Configure projects for major browsers */
+  projects: [
+    {
+      name: 'chromium',
+      use: {
+        ...devices['Desktop Chrome'],
+      },
+    },
+    // For now we only test Chrome!
+    // {
+    //   name: 'firefox',
+    //   use: {
+    //     ...devices['Desktop Firefox'],
+    //   },
+    // },
+    // {
+    //   name: 'webkit',
+    //   use: {
+    //     ...devices['Desktop Safari'],
+    //   },
+    // },
+  ],
+
+  /* Run your local dev server before starting the tests */
+  webServer: {
+    command: 'pnpm start',
+    port: 3030,
+    env: {
+      PORT: '3030',
+    },
+  },
+};
+
+export default config;

dev-packages/e2e-tests/test-applications/standard-frontend-react/src/index.tsx

@@ -38,12 +38,6 @@ Sentry.init({
   replaysOnErrorSampleRate: 0.0,
 });
 
-Object.defineProperty(window, 'sentryReplayId', {
-  get() {
-    return replay['_replay'].session.id;
-  },
-});
-
 Sentry.addEventProcessor(event => {
   if (
     event.type === 'transaction' &&

dev-packages/e2e-tests/test-applications/standard-frontend-react/tests/behaviour-test.spec.ts

@@ -1,5 +1,4 @@
 import { expect, test } from '@playwright/test';
-import { ReplayRecordingData } from './fixtures/ReplayRecordingData';
 
 const EVENT_POLLING_TIMEOUT = 90_000;
 
@@ -139,62 +138,3 @@ test('Sends a navigation transaction to Sentry', async ({ page }) => {
 
   expect(hadPageNavigationTransaction).toBe(true);
 });
-
-test('Sends a Replay recording to Sentry', async ({ browser }) => {
-  const context = await browser.newContext();
-  const page = await context.newPage();
-
-  await page.goto('/');
-
-  const replayId = await page.waitForFunction(() => {
-    return window.sentryReplayId;
-  });
-
-  // Keypress event ensures LCP is finished
-  await page.type('body', 'Y');
-
-  // Wait for replay to be sent
-
-  if (replayId === undefined) {
-    throw new Error("Application didn't set a replayId");
-  }
-
-  console.log(`Polling for replay with ID: ${replayId}`);
-
-  await expect
-    .poll(
-      async () => {
-        const response = await fetch(
-          `https://sentry.io/api/0/projects/${sentryTestOrgSlug}/${sentryTestProject}/replays/${replayId}/`,
-          { headers: { Authorization: `Bearer ${authToken}` } },
-        );
-        return response.status;
-      },
-      {
-        timeout: EVENT_POLLING_TIMEOUT,
-      },
-    )
-    .toBe(200);
-
-  // now fetch the first recording segment
-  await expect
-    .poll(
-      async () => {
-        const response = await fetch(
-          `https://sentry.io/api/0/projects/${sentryTestOrgSlug}/${sentryTestProject}/replays/${replayId}/recording-segments/?cursor=100%3A0%3A1`,
-          { headers: { Authorization: `Bearer ${authToken}` } },
-        );
-
-        if (response.ok) {
-          const data = await response.json();
-          return data[0];
-        }
-
-        return response.status;
-      },
-      {
-        timeout: EVENT_POLLING_TIMEOUT,
-      },
-    )
-    .toEqual(ReplayRecordingData);
-});