explicitly await request response

Author: Lms24

packages/integration-tests/suites/replay/requests/init.js

@@ -3,7 +3,7 @@ import * as Sentry from '@sentry/browser';
 window.Sentry = Sentry;
 window.Replay = new Sentry.Replay({
   flushMinDelay: 200,
-  flushMaxDelay: 1000,
+  flushMaxDelay: 2000,
   useCompression: false,
 });
 

packages/integration-tests/suites/replay/requests/test.ts

@@ -1,7 +1,6 @@
 import { expect } from '@playwright/test';
 
 import { sentryTest } from '../../../utils/fixtures';
-import { envelopeRequestParser } from '../../../utils/helpers';
 import { expectedFetchPerformanceSpan, expectedXHRPerformanceSpan } from '../../../utils/replayEventTemplates';
 import { getReplayRecordingContent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
 
@@ -15,9 +14,6 @@ for (let i = 0; i < 25; i++) {
     const reqPromise1 = waitForReplayRequest(page, 1);
 
     await page.route('https://dsn.ingest.sentry.io/**/*', route => {
-      // eslint-disable-next-line no-console
-      console.log('>>>got request', envelopeRequestParser(route.request())?.type);
-
       return route.fulfill({
         status: 200,
         contentType: 'application/json',
@@ -26,8 +22,6 @@ for (let i = 0; i < 25; i++) {
     });
 
     await page.route('https://example.com', route => {
-      // eslint-disable-next-line no-console
-      console.log('>>>got request call');
       return route.fulfill({
         status: 200,
         contentType: 'application/json',
@@ -41,7 +35,12 @@ for (let i = 0; i < 25; i++) {
     await page.click('#go-background');
     const { performanceSpans: spans0 } = getReplayRecordingContent(await reqPromise0);
 
+    const receivedResponse = page.waitForResponse(res => {
+      return res.url().includes('example.com');
+    });
     await page.click('#fetch');
+    await receivedResponse;
+
     await page.click('#go-background');
     const { performanceSpans: spans1 } = getReplayRecordingContent(await reqPromise1);
 
@@ -58,8 +57,6 @@ for (let i = 0; i < 25; i++) {
     const reqPromise1 = waitForReplayRequest(page, 1);
 
     await page.route('https://dsn.ingest.sentry.io/**/*', route => {
-      // eslint-disable-next-line no-console
-      console.log('>>>got request', envelopeRequestParser(route.request())?.type);
       return route.fulfill({
         status: 200,
         contentType: 'application/json',
@@ -68,8 +65,6 @@ for (let i = 0; i < 25; i++) {
     });
 
     await page.route('https://example.com', route => {
-      // eslint-disable-next-line no-console
-      console.log('>>>got request call');
       return route.fulfill({
         status: 200,
         contentType: 'application/json',
@@ -83,7 +78,12 @@ for (let i = 0; i < 25; i++) {
     await page.click('#go-background');
     const { performanceSpans: spans0 } = getReplayRecordingContent(await reqPromise0);
 
+    const receivedResponse = page.waitForResponse(res => {
+      return res.url().includes('example.com');
+    });
     await page.click('#xhr');
+    await receivedResponse;
+
     await page.click('#go-background');
     const { performanceSpans: spans1 } = getReplayRecordingContent(await reqPromise1);