test: Fix flaky replay sampling test (#7749)

Author: mydea

.github/workflows/flaky-test-detector.yml

@@ -6,7 +6,6 @@ on:
       - 'packages/browser-integration-tests/suites/**'
     branches-ignore:
       - master
-      - develop
 
 env:
   HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }}
@@ -27,6 +26,8 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 60
     name: 'Check tests for flakiness'
+    # Also skip if PR is from master -> develop
+    if: ${{ github.base_ref != 'master' && github.ref != 'refs/heads/master' }}
     steps:
       - name: Check out current branch
         uses: actions/checkout@v3

packages/browser-integration-tests/suites/replay/sampling/test.ts

@@ -1,4 +1,5 @@
 import { expect } from '@playwright/test';
+import type { ReplayContainer } from '@sentry/replay/build/npm/types/types';
 
 import { sentryTest } from '../../../utils/fixtures';
 import { getReplaySnapshot, shouldSkipReplayTest } from '../../../utils/replayHelpers';
@@ -24,6 +25,10 @@ sentryTest('should not send replays if both sample rates are 0', async ({ getLoc
 
   await page.click('button');
 
+  await page.waitForFunction(() => {
+    const replayIntegration = (window as unknown as Window & { Replay: { _replay: ReplayContainer } }).Replay;
+    return !!replayIntegration._replay.session;
+  });
   const replay = await getReplaySnapshot(page);
 
   expect(replay.session?.sampled).toBe(false);