Skip to content

Commit c99357a

Browse files
committed
Merge branch 'feat-replay-change-stop-flush-clear-session' into feat-replay-change-sampling-logic
2 parents bdb78f2 + dc8cd6c commit c99357a

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

packages/replay/src/replay.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import type {
2020
RecordingOptions,
2121
ReplayContainer as ReplayContainerInterface,
2222
ReplayExperimentalPluginOptions,
23-
ReplayFlushOptions,
2423
ReplayPluginOptions,
2524
SendBufferedReplayOptions,
2625
Session,
@@ -921,7 +920,16 @@ export class ReplayContainer implements ReplayContainerInterface {
921920
* Flush recording data to Sentry. Creates a lock so that only a single flush
922921
* can be active at a time. Do not call this directly.
923922
*/
924-
private _flush = async ({ force = false }: ReplayFlushOptions = {}): Promise<void> => {
923+
private _flush = async ({
924+
force = false,
925+
}: {
926+
/**
927+
* If true, flush while ignoring the `_isEnabled` state of
928+
* Replay integration. (By default, flush is noop if integration
929+
* is stopped).
930+
*/
931+
force?: boolean;
932+
} = {}): Promise<void> => {
925933
if (!this._isEnabled && !force) {
926934
// This can happen if e.g. the replay was stopped because of exceeding the retry limit
927935
return;

packages/replay/src/types.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -493,15 +493,6 @@ export interface ReplayContainer {
493493
setInitialState(): void;
494494
}
495495

496-
export interface ReplayFlushOptions {
497-
/**
498-
* If true, flush while ignoring the `_isEnabled` state of
499-
* Replay integration. (By default, flush is noop if integration
500-
* is stopped).
501-
*/
502-
force?: boolean;
503-
}
504-
505496
export interface ReplayPerformanceEntry<T> {
506497
/**
507498
* One of these types https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry/entryType

0 commit comments

Comments
 (0)