fix(utils): Remove WINDOW from utils (#6024)

This issue is caused by the fact that `Window` ends up in the utils type definitions.

This PR:
- Removes `WINDOW` from utils
- In utils, it's usage is replaced with the following at the top of the appropriate files:
   ```ts
   // eslint-disable-next-line deprecation/deprecation. 
   const WINDOW = getGlobalObject<Window>();
   ```
- Adds `WINDOW` to: 
  - `@sentry/browser` where it is exported for use elsewhere
  - `@sentry/tracing/browser` - Can be removed once tracing is split into browser/node code
  - The `Offline` and `ReportingObserver` integrations since they don't have any dependencies other than utils
    - These could probably just use `window` since they're not used outside the browser
- All downstream SDKs then import `WINDOW` from `@sentry/browser` or `@sentry/react`

Author: timfish

packages/angular/src/tracing.ts

@@ -1,9 +1,9 @@
 /* eslint-disable max-lines */
 import { AfterViewInit, Directive, Injectable, Input, NgModule, OnDestroy, OnInit } from '@angular/core';
 import { ActivatedRouteSnapshot, Event, NavigationEnd, NavigationStart, ResolveEnd, Router } from '@angular/router';
-import { getCurrentHub } from '@sentry/browser';
+import { getCurrentHub, WINDOW } from '@sentry/browser';
 import { Span, Transaction, TransactionContext } from '@sentry/types';
-import { logger, stripUrlQueryAndFragment, timestampWithMs, WINDOW } from '@sentry/utils';
+import { logger, stripUrlQueryAndFragment, timestampWithMs } from '@sentry/utils';
 import { Observable, Subscription } from 'rxjs';
 import { filter, tap } from 'rxjs/operators';
 

packages/browser/src/client.ts

@@ -1,15 +1,9 @@
 import { BaseClient, getCurrentHub, getEnvelopeEndpointWithUrlEncodedAuth, Scope, SDK_VERSION } from '@sentry/core';
 import { ClientOptions, Event, EventHint, Options, Severity, SeverityLevel } from '@sentry/types';
-import {
-  createClientReportEnvelope,
-  dsnToString,
-  getEventDescription,
-  logger,
-  serializeEnvelope,
-  WINDOW,
-} from '@sentry/utils';
+import { createClientReportEnvelope, dsnToString, getEventDescription, logger, serializeEnvelope } from '@sentry/utils';
 
 import { eventFromException, eventFromMessage } from './eventbuilder';
+import { WINDOW } from './helpers';
 import { Breadcrumbs } from './integrations';
 import { BREADCRUMB_INTEGRATION_ID } from './integrations/breadcrumbs';
 import { BrowserTransportOptions } from './transports/types';

packages/browser/src/exports.ts

@@ -45,6 +45,7 @@ export {
   InboundFilters,
 } from '@sentry/core';
 
+export { WINDOW } from './helpers';
 export { BrowserClient } from './client';
 export { makeFetchTransport, makeXHRTransport } from './transports';
 export {

packages/browser/src/helpers.ts

@@ -5,9 +5,12 @@ import {
   addExceptionTypeValue,
   addNonEnumerableProperty,
   getOriginalFunction,
+  GLOBAL_OBJ,
   markFunctionWrapped,
 } from '@sentry/utils';
 
+export const WINDOW = GLOBAL_OBJ as typeof GLOBAL_OBJ & Window;
+
 let ignoreOnError: number = 0;
 
 /**

packages/browser/src/index.ts

@@ -1,8 +1,8 @@
 export * from './exports';
 
 import { Integrations as CoreIntegrations } from '@sentry/core';
-import { WINDOW } from '@sentry/utils';
 
+import { WINDOW } from './helpers';
 import * as BrowserIntegrations from './integrations';
 
 let windowIntegrations = {};

packages/browser/src/integrations/breadcrumbs.ts

@@ -8,9 +8,10 @@ import {
   parseUrl,
   safeJoin,
   severityLevelFromString,
-  WINDOW,
 } from '@sentry/utils';
 
+import { WINDOW } from '../helpers';
+
 /** JSDoc */
 interface BreadcrumbsOptions {
   console: boolean;

packages/browser/src/integrations/httpcontext.ts

@@ -1,6 +1,7 @@
 import { addGlobalEventProcessor, getCurrentHub } from '@sentry/core';
 import { Event, Integration } from '@sentry/types';
-import { WINDOW } from '@sentry/utils';
+
+import { WINDOW } from '../helpers';
 
 /** HttpContext integration collects information about HTTP request headers */
 export class HttpContext implements Integration {

packages/browser/src/integrations/trycatch.ts

@@ -1,7 +1,7 @@
 import { Integration, WrappedFunction } from '@sentry/types';
-import { fill, getFunctionName, getOriginalFunction, WINDOW } from '@sentry/utils';
+import { fill, getFunctionName, getOriginalFunction } from '@sentry/utils';
 
-import { wrap } from '../helpers';
+import { WINDOW, wrap } from '../helpers';
 
 const DEFAULT_EVENT_TARGET = [
   'EventTarget',

packages/browser/src/sdk.ts

@@ -12,11 +12,10 @@ import {
   resolvedSyncPromise,
   stackParserFromStackParserOptions,
   supportsFetch,
-  WINDOW,
 } from '@sentry/utils';
 
 import { BrowserClient, BrowserClientOptions, BrowserOptions } from './client';
-import { ReportDialogOptions, wrap as internalWrap } from './helpers';
+import { ReportDialogOptions, WINDOW, wrap as internalWrap } from './helpers';
 import { Breadcrumbs, Dedupe, GlobalHandlers, HttpContext, LinkedErrors, TryCatch } from './integrations';
 import { defaultStackParser } from './stack-parsers';
 import { makeFetchTransport, makeXHRTransport } from './transports';

packages/browser/src/transports/utils.ts

@@ -1,4 +1,6 @@
-import { isNativeFetch, logger, WINDOW } from '@sentry/utils';
+import { isNativeFetch, logger } from '@sentry/utils';
+
+import { WINDOW } from '../helpers';
 
 let cachedFetchImpl: FetchImpl;