fix(node): Record local variables with falsy values (v7) (#11190)

Backport to v7 of #10821

Author: timfish

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.js

@@ -20,6 +20,9 @@ function one(name) {
     name,
     num: 5,
   };
+  const bool = false;
+  const num = 0;
+  const str = '';
 
   const ty = new Some();
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-caught.mjs

@@ -22,6 +22,9 @@ function one(name) {
     functionsShouldNotBeIncluded: () => {},
     functionsShouldNotBeIncluded2() {},
   };
+  const bool = false;
+  const num = 0;
+  const str = '';
 
   const ty = new Some();
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-memory-test.js

@@ -22,6 +22,9 @@ function one(name) {
     name,
     num: 5,
   };
+  const bool = false;
+  const num = 0;
+  const str = '';
 
   const ty = new Some();
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables.js

@@ -24,6 +24,9 @@ function one(name) {
     name,
     num: 5,
   };
+  const bool = false;
+  const num = 0;
+  const str = '';
 
   const ty = new Some();
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/no-local-variables.js

@@ -23,6 +23,9 @@ function one(name) {
     name,
     num: 5,
   };
+  const bool = false;
+  const num = 0;
+  const str = '';
 
   const ty = new Some();
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/test.ts

@@ -16,6 +16,9 @@ const EXPECTED_LOCAL_VARIABLES_EVENT = {
                 arr: [1, '2', null],
                 obj: { name: 'some name', num: 5 },
                 ty: '<Some>',
+                bool: false,
+                num: 0,
+                str: '',
               },
             }),
             expect.objectContaining({

packages/node/src/integrations/local-variables/local-variables-async.ts

@@ -42,9 +42,9 @@ async function unrollObject(session: Session, objectId: string, name: string, va
 }
 
 function unrollOther(prop: Runtime.PropertyDescriptor, vars: Variables): void {
-  if (prop?.value?.value) {
+  if (prop?.value?.value != null) {
     vars[prop.name] = prop.value.value;
-  } else if (prop?.value?.description && prop?.value?.type !== 'function') {
+  } else if (prop?.value?.description != null && prop?.value?.type !== 'function') {
     vars[prop.name] = `<${prop.value.description}>`;
   }
 }
@@ -63,7 +63,7 @@ async function getLocalVariables(session: Session, objectId: string): Promise<Va
     } else if (prop?.value?.objectId && prop?.value?.className === 'Object') {
       const id = prop.value.objectId;
       await unrollObject(session, id, prop.name, variables);
-    } else if (prop?.value?.value || prop?.value?.description) {
+    } else if (prop?.value?.value != null || prop?.value?.description != null) {
       unrollOther(prop, variables);
     }
   }

packages/node/src/integrations/local-variables/local-variables-sync.ts

@@ -129,7 +129,7 @@ class AsyncSession implements DebugSession {
         } else if (prop?.value?.objectId && prop?.value?.className === 'Object') {
           const id = prop.value.objectId;
           add(vars => this._unrollObject(id, prop.name, vars, next));
-        } else if (prop?.value?.value || prop?.value?.description) {
+        } else if (prop?.value?.value != null || prop?.value?.description != null) {
           add(vars => this._unrollOther(prop, vars, next));
         }
       }
@@ -192,9 +192,9 @@ class AsyncSession implements DebugSession {
    * Unrolls other properties
    */
   private _unrollOther(prop: Runtime.PropertyDescriptor, vars: Variables, next: (vars: Variables) => void): void {
-    if (prop?.value?.value) {
+    if (prop?.value?.value != null) {
       vars[prop.name] = prop.value.value;
-    } else if (prop?.value?.description && prop?.value?.type !== 'function') {
+    } else if (prop?.value?.description != null && prop?.value?.type !== 'function') {
       vars[prop.name] = `<${prop.value.description}>`;
     }