Revert "force report lcp on finish"

This reverts commit e68a672.

Author: AbhiPrasad

packages/tracing/src/browser/metrics.ts

@@ -21,7 +21,6 @@ export class MetricsInstrumentation {
   private _performanceCursor: number = 0;
   private _lcpEntry: LargestContentfulPaint | undefined;
   private _clsEntry: LayoutShift | undefined;
-  private _reportLCP: ReturnType<typeof getLCP>;
 
   public constructor(private _reportAllChanges: boolean = false) {
     if (!isNodeEnv() && global && global.performance && global.document) {
@@ -44,12 +43,6 @@ export class MetricsInstrumentation {
 
     logger.log('[Tracing] Adding & adjusting spans using Performance API');
 
-    // `addPerformanceEntries` should be called on transaction.finish
-    // If we are finishing a transaction, we should force report the LCP.
-    if (this._reportLCP) {
-      this._reportLCP(true);
-    }
-
     const timeOrigin = msToSec(browserPerformanceTimeOrigin);
 
     let responseStartTimestamp: number | undefined;
@@ -230,7 +223,7 @@ export class MetricsInstrumentation {
 
   /** Starts tracking the Largest Contentful Paint on the current page. */
   private _trackLCP(): void {
-    this._reportLCP = getLCP(metric => {
+    getLCP(metric => {
       const entry = metric.entries.pop();
       if (!entry) {
         return;

packages/tracing/src/browser/web-vitals/getLCP.ts

@@ -34,13 +34,10 @@ export interface LargestContentfulPaint extends PerformanceEntry {
 
 const reportedMetricIDs: Record<string, boolean> = {};
 
-export const getLCP = (
-  onReport: ReportHandler,
-  reportAllChanges?: boolean,
-): ReturnType<typeof bindReporter> | undefined => {
+export const getLCP = (onReport: ReportHandler, reportAllChanges?: boolean): void => {
   const visibilityWatcher = getVisibilityWatcher();
   const metric = initMetric('LCP');
-  let report: ReturnType<typeof bindReporter> | undefined;
+  let report: ReturnType<typeof bindReporter>;
 
   const entryHandler = (entry: PerformanceEntry): void => {
     // The startTime attribute returns the value of the renderTime if it is not 0,
@@ -69,9 +66,7 @@ export const getLCP = (
         po.takeRecords().map(entryHandler as PerformanceEntryHandler);
         po.disconnect();
         reportedMetricIDs[metric.id] = true;
-        if (report) {
-          report(true);
-        }
+        report(true);
       }
     };
 
@@ -84,6 +79,4 @@ export const getLCP = (
 
     onHidden(stopListening, true);
   }
-
-  return report;
 };