fix & improve plugin & test

Author: mydea

.github/workflows/build.yml

@@ -1021,7 +1021,7 @@ jobs:
             'sveltekit',
             'sveltekit-2',
             'generic-ts3.8',
-            'node-experimental-fastify-app',
+            'node-fastify-app',
             # TODO(v8): Re-enable hapi tests
             # 'node-hapi-app',
             'node-exports-test-app',

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/.gitignore renamed to dev-packages/e2e-tests/test-applications/node-fastify-app/.gitignore

@@ -1,5 +1,5 @@
 {
-  "name": "node-experimental-fastify-app",
+  "name": "node-fastify-app",
   "version": "1.0.0",
   "private": true,
   "scripts": {
@@ -17,7 +17,6 @@
     "@sentry/opentelemetry": "latest || *",
     "@types/node": "18.15.1",
     "fastify": "4.23.2",
-    "fastify-plugin": "4.5.1",
     "typescript": "4.9.5",
     "ts-node": "10.9.1"
   },

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/.npmrc renamed to dev-packages/e2e-tests/test-applications/node-fastify-app/.npmrc

@@ -52,6 +52,10 @@ app.get('/test-error', async function (req, res) {
   res.send({ exceptionId });
 });
 
+app.get('/test-exception', async function (req, res) {
+  throw new Error('This is an exception');
+});
+
 app.listen({ port: port });
 
 function makeHttpRequest(url) {

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/event-proxy-server.ts renamed to dev-packages/e2e-tests/test-applications/node-fastify-app/event-proxy-server.ts

@@ -2,5 +2,5 @@ import { startEventProxyServer } from './event-proxy-server';
 
 startEventProxyServer({
   port: 3031,
-  proxyServerName: 'node-experimental-fastify-app',
+  proxyServerName: 'node-fastify-app',
 });

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/package.json renamed to dev-packages/e2e-tests/test-applications/node-fastify-app/package.json

@@ -1,5 +1,6 @@
 import { expect, test } from '@playwright/test';
 import axios, { AxiosError } from 'axios';
+import { waitForError } from '../event-proxy-server';
 
 const authToken = process.env.E2E_TEST_AUTH_TOKEN;
 const sentryTestOrgSlug = process.env.E2E_TEST_SENTRY_ORG_SLUG;
@@ -37,3 +38,36 @@ test('Sends exception to Sentry', async ({ baseURL }) => {
     )
     .toBe(200);
 });
+
+test('Sends correct error event', async ({ baseURL }) => {
+  const errorEventPromise = waitForError('node-fastify-app', event => {
+    return !event.type;
+  });
+
+  await axios.get(`${baseURL}/test-exception`);
+
+  const errorEvent = await errorEventPromise;
+
+  console.log(JSON.stringify(errorEvent, null, 2));
+
+  expect(errorEvent.exception?.values).toHaveLength(1);
+  expect(errorEvent.exception?.values?.[0]?.value).toBe('This is an exception.');
+
+  expect(errorEvent.request).toEqual({});
+
+  expect(errorEvent).toEqual({
+    request: {
+      method: 'GET',
+      cookies: {},
+      headers: expect.any(Object),
+      url: 'http://localhost:3030/test-exception',
+    },
+  });
+
+  expect(errorEvent.transaction).toEqual('GET /test-exception');
+
+  expect(errorEvent.contexts?.trace).toEqual({
+    trace_id: expect.any(String),
+    span_id: expect.any(String),
+  });
+});