meta: beta.4

Author: HazAT

lerna.json

@@ -1,6 +1,6 @@
 {
   "lerna": "3.4.0",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "packages": "packages/*",
   "ignore": "raven-*",
   "npmClient": "yarn",

packages/browser/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/browser",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "description": "Official Sentry SDK for browsers",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/browser",
@@ -16,9 +16,9 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/core": "5.6.0-beta.3",
-    "@sentry/types": "5.6.0-beta.3",
-    "@sentry/utils": "5.6.0-beta.3",
+    "@sentry/core": "5.6.0-beta.4",
+    "@sentry/types": "5.6.0-beta.4",
+    "@sentry/utils": "5.6.0-beta.4",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

packages/browser/src/version.ts

@@ -1,2 +1,2 @@
 export const SDK_NAME = 'sentry.javascript.browser';
-export const SDK_VERSION = '5.6.0-beta.3';
+export const SDK_VERSION = '5.6.0-beta.4';

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/core",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "description": "Base implementation for all Sentry JavaScript SDKs",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/core",
@@ -16,10 +16,10 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/hub": "5.6.0-beta.3",
-    "@sentry/minimal": "5.6.0-beta.3",
-    "@sentry/types": "5.6.0-beta.3",
-    "@sentry/utils": "5.6.0-beta.3",
+    "@sentry/hub": "5.6.0-beta.4",
+    "@sentry/minimal": "5.6.0-beta.4",
+    "@sentry/types": "5.6.0-beta.4",
+    "@sentry/utils": "5.6.0-beta.4",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

packages/hub/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/hub",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "description": "Sentry hub which handles global state managment.",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/hub",
@@ -16,8 +16,8 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/types": "5.6.0-beta.3",
-    "@sentry/utils": "5.6.0-beta.3",
+    "@sentry/types": "5.6.0-beta.4",
+    "@sentry/utils": "5.6.0-beta.4",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

packages/hub/src/hub.ts

@@ -444,11 +444,11 @@ export class Hub implements HubInterface {
 
     // TODO: if sampled do what?
 
-    const finishedSpans = passedSpan.finishedSpans.filter(s => s !== span);
+    const finishedSpans = passedSpan.finishedSpans.filter(s => s !== passedSpan);
 
     const eventId = this.captureEvent({
       contexts: { trace: passedSpan.getTraceContext() },
-      spans: finishedSpans,
+      spans: finishedSpans.length > 0 ? finishedSpans : undefined,
       start_timestamp: passedSpan.startTimestamp,
       timestamp: passedSpan.timestamp,
       transaction: passedSpan.transaction,

packages/hub/test/hub.test.ts

@@ -323,6 +323,18 @@ describe('Hub', () => {
         const span = hub.startSpan({ transaction: 'test' }, true) as any;
         expect(hub.finishSpan(span)).toBeDefined();
         expect(spy).toHaveBeenCalled();
+        expect(spy.mock.calls[0][0].spans).toBeUndefined();
+      });
+
+      test('finish a scope span with transaction + child span', () => {
+        const myScope = new Scope();
+        const hub = new Hub(clientFn, myScope);
+        const spy = jest.spyOn(hub as any, 'captureEvent');
+        const span = hub.startSpan({ transaction: 'test' }, true) as any;
+        hub.finishSpan(hub.startSpan());
+        expect(hub.finishSpan(span)).toBeDefined();
+        expect(spy).toHaveBeenCalled();
+        expect(spy.mock.calls[0][0].spans).toHaveLength(1);
       });
     });
   });

packages/integrations/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/integrations",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "description": "Pluggable integrations that can be used to enchance JS SDKs",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/integrations",
@@ -16,8 +16,8 @@
   "module": "esm/index.js",
   "types": "dist/index.d.ts",
   "dependencies": {
-    "@sentry/types": "5.6.0-beta.3",
-    "@sentry/utils": "5.6.0-beta.3",
+    "@sentry/types": "5.6.0-beta.4",
+    "@sentry/utils": "5.6.0-beta.4",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

packages/minimal/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/minimal",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "description": "Sentry minimal library that can be used in other packages",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/minimal",
@@ -16,8 +16,8 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/hub": "5.6.0-beta.3",
-    "@sentry/types": "5.6.0-beta.3",
+    "@sentry/hub": "5.6.0-beta.4",
+    "@sentry/types": "5.6.0-beta.4",
     "tslib": "^1.9.3"
   },
   "devDependencies": {

packages/node/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sentry/node",
-  "version": "5.6.0-beta.3",
+  "version": "5.6.0-beta.4",
   "description": "Offical Sentry SDK for Node.js",
   "repository": "git://github.com/getsentry/sentry-javascript.git",
   "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/node",
@@ -16,10 +16,10 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry/core": "5.6.0-beta.3",
-    "@sentry/hub": "5.6.0-beta.3",
-    "@sentry/types": "5.6.0-beta.3",
-    "@sentry/utils": "5.6.0-beta.3",
+    "@sentry/core": "5.6.0-beta.4",
+    "@sentry/hub": "5.6.0-beta.4",
+    "@sentry/types": "5.6.0-beta.4",
+    "@sentry/utils": "5.6.0-beta.4",
     "cookie": "0.3.1",
     "https-proxy-agent": "2.2.1",
     "lru_map": "0.3.3",