all the feedback2 stuff

Author: ryan953

packages/core/src/baseclient.ts

@@ -490,6 +490,12 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
     callback: (feedback: FeedbackEvent, options?: { includeReplay: boolean }) => void,
   ): void;
 
+  /** @inheritdoc */
+  public on(
+    hook: 'createFeedbackModal',
+    callback: (options: Record<string, unknown>, appendChild: (child: HTMLElement) => void) => void,
+  ): void;
+
   /** @inheritdoc */
   public on(hook: 'startPageLoadSpan', callback: (options: StartSpanOptions) => void): void;
 
@@ -536,6 +542,13 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
   /** @inheritdoc */
   public emit(hook: 'beforeSendFeedback', feedback: FeedbackEvent, options?: { includeReplay: boolean }): void;
 
+  /** @inheritdoc */
+  public emit(
+    hook: 'createFeedbackModal',
+    options: Record<string, unknown>,
+    appendChild: (child: HTMLElement) => void,
+  ): void;
+
   /** @inheritdoc */
   public emit(hook: 'startPageLoadSpan', options: StartSpanOptions): void;
 

packages/feedback-async/src/types/index.ts

@@ -80,8 +80,6 @@ export interface FeedbackGeneralConfiguration {
     email: string;
     name: string;
   };
-
-  // getScreenshotIntegration: () => Integration;
 }
 
 /**

packages/feedback2-modal/package.json

@@ -29,7 +29,6 @@
     "access": "public"
   },
   "dependencies": {
-    "@sentry-internal/feedback-screenshot": "7.100.0",
     "@sentry/core": "7.100.0",
     "@sentry/types": "7.100.0",
     "@sentry/utils": "7.100.0",

packages/feedback2-modal/src/constants.ts

@@ -4,3 +4,4 @@ import { GLOBAL_OBJ } from '@sentry/utils';
 // prevents the browser package from being bundled in the CDN bundle, and avoids a
 // circular dependency between the browser and feedback packages
 export const WINDOW = GLOBAL_OBJ as typeof GLOBAL_OBJ & Window;
+export const DOCUMENT = WINDOW.document;

packages/feedback2/src/constants.ts renamed to packages/feedback2-modal/src/constants/index.ts

@@ -4,3 +4,4 @@ import { GLOBAL_OBJ } from '@sentry/utils';
 // prevents the browser package from being bundled in the CDN bundle, and avoids a
 // circular dependency between the browser and feedback packages
 export const WINDOW = GLOBAL_OBJ as typeof GLOBAL_OBJ & Window;
+export const DOCUMENT = WINDOW.document;

packages/feedback2-modal/src/debug-build.ts

@@ -0,0 +1,8 @@
+declare const __DEBUG_BUILD__: boolean;
+
+/**
+ * This serves as a build time flag that will be true by default, but false in non-debug builds or if users replace `__SENTRY_DEBUG__` in their generated code.
+ *
+ * ATTENTION: This constant must never cross package boundaries (i.e. be exported) to guarantee that it can be used for tree shaking.
+ */
+export const DEBUG_BUILD = __DEBUG_BUILD__;

packages/feedback2-modal/src/index.ts

@@ -1,5 +1,5 @@
 export {
   // eslint-disable-next-line deprecation/deprecation
-  FeedbackAsync,
-  feedbackAsyncIntegration,
+  Feedback2Modal,
+  feedback2ModalIntegration,
 } from './integration';