Skip to content

Commit b9db2e6

Browse files
authored
ref(feedback) set submission timeout to 30 seconds (#16918)
1 parent ccbf627 commit b9db2e6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

packages/feedback/src/core/sendFeedback.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ export const sendFeedback: SendFeedback = (
3434

3535
// We want to wait for the feedback to be sent (or not)
3636
return new Promise<string>((resolve, reject) => {
37-
// After 5s, we want to clear anyhow
38-
const timeout = setTimeout(() => reject('Unable to determine if Feedback was correctly sent.'), 5_000);
37+
// After 30s, we want to clear anyhow
38+
const timeout = setTimeout(() => reject('Unable to determine if Feedback was correctly sent.'), 30_000);
3939

4040
const cleanup = client.on('afterSendEvent', (event: Event, response: TransportMakeRequestResponse) => {
4141
if (event.event_id !== eventId) {

packages/feedback/test/core/sendFeedback.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ describe('sendFeedback', () => {
321321

322322
mockSdk();
323323
vi.spyOn(getClient()!.getTransport()!, 'send').mockImplementation(() => {
324-
return new Promise(resolve => setTimeout(resolve, 10_000));
324+
return new Promise(resolve => setTimeout(resolve, 40_000));
325325
});
326326

327327
const promise = sendFeedback({
@@ -330,7 +330,7 @@ describe('sendFeedback', () => {
330330
message: 'mi',
331331
});
332332

333-
vi.advanceTimersByTime(5_000);
333+
vi.advanceTimersByTime(30_000);
334334

335335
await expect(promise).rejects.toMatch('Unable to determine if Feedback was correctly sent.');
336336

0 commit comments

Comments
 (0)