Skip to content

Commit ae747ad

Browse files
authored
test(e2e): Pin [email protected] due to @vercel/nft incompatibility (#17777)
This PR unblocks our CI which pas failing because: - Nuxt and SolidStart rely on nitro which relies on on `@vercel/nft` - `import-in-the-middle` received a [bug fix ](https://github.com/nodejs/import-in-the-middle/pull/205/files) which mixes `require` and `import` statements in `hooks.mjs`. This was released [in `1.14.3`](https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.14.3) - Apparently, nft can't trace modules that use both, `import` and `require` statements, so the `require`'d `hooks.js` file is not added to the subset of modules nft returns (we're working on a minimal reproduction and bug report for nft) As a result, we have to pin IITM to the version before the bugfix (`1.14.2`) until either IITM reverts the fix or NFT releases a fix. The terrible part about this though is that users have to do the same thing for now and there's nothing we can do besides documenting to add an override for IITM. Being a JS developer is fun they said...
1 parent be0c75d commit ae747ad

File tree

9 files changed

+42
-1
lines changed

9 files changed

+42
-1
lines changed

dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,10 @@
2323
},
2424
"volta": {
2525
"extends": "../../package.json"
26+
},
27+
"pnpm": {
28+
"overrides": {
29+
"import-in-the-middle": "1.14.2"
30+
}
2631
}
2732
}

dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
"overrides": {
3030
"nitropack": "2.10.0",
3131
"ofetch": "1.4.0",
32-
"@vercel/nft": "0.29.4"
32+
"@vercel/nft": "0.29.4",
33+
"import-in-the-middle": "1.14.2"
3334
}
3435
},
3536
"volta": {

dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,10 @@
2424
},
2525
"volta": {
2626
"extends": "../../package.json"
27+
},
28+
"pnpm": {
29+
"overrides": {
30+
"import-in-the-middle": "1.14.2"
31+
}
2732
}
2833
}

dev-packages/e2e-tests/test-applications/nuxt-3/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,10 @@
3434
},
3535
"volta": {
3636
"extends": "../../package.json"
37+
},
38+
"pnpm": {
39+
"overrides": {
40+
"import-in-the-middle": "1.14.2"
41+
}
3742
}
3843
}

dev-packages/e2e-tests/test-applications/nuxt-4/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,10 @@
3434
"label": "nuxt-4 (canary)"
3535
}
3636
]
37+
},
38+
"pnpm": {
39+
"overrides": {
40+
"import-in-the-middle": "1.14.2"
41+
}
3742
}
3843
}

dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,10 @@
3434
},
3535
"volta": {
3636
"extends": "../../package.json"
37+
},
38+
"pnpm": {
39+
"overrides": {
40+
"import-in-the-middle": "1.14.2"
41+
}
3742
}
3843
}

dev-packages/e2e-tests/test-applications/solidstart-spa/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,10 @@
3434
},
3535
"volta": {
3636
"extends": "../../package.json"
37+
},
38+
"pnpm": {
39+
"overrides": {
40+
"import-in-the-middle": "1.14.2"
41+
}
3742
}
3843
}

dev-packages/e2e-tests/test-applications/solidstart-top-level-import/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,10 @@
3434
},
3535
"volta": {
3636
"extends": "../../package.json"
37+
},
38+
"pnpm": {
39+
"overrides": {
40+
"import-in-the-middle": "1.14.2"
41+
}
3742
}
3843
}

dev-packages/e2e-tests/test-applications/solidstart/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,10 @@
3434
},
3535
"volta": {
3636
"extends": "../../package.json"
37+
},
38+
"pnpm": {
39+
"overrides": {
40+
"import-in-the-middle": "1.14.2"
41+
}
3742
}
3843
}

0 commit comments

Comments
 (0)