revert getTransaction() change, skip tests that breaks

Author: lobsterkatie

packages/hub/src/scope.ts

@@ -212,7 +212,11 @@ export class Scope implements ScopeInterface {
    * @inheritDoc
    */
   public getTransaction(): Transaction | undefined {
-    return this.getSpan() as Transaction;
+    const span = this.getSpan() as Span & { spanRecorder: { spans: Span[] } };
+    if (span && span.spanRecorder && span.spanRecorder.spans[0]) {
+      return span.spanRecorder.spans[0] as Transaction;
+    }
+    return undefined;
   }
 
   /**

packages/tracing/test/browser/browsertracing.test.ts

@@ -178,7 +178,8 @@ describe('BrowserTracing', () => {
         expect(mockBeforeNavigation).toHaveBeenCalledTimes(1);
       });
 
-      it('creates a transaction with sampled = false if it returns undefined', () => {
+      // TODO add this back in once getTransaction() returns sampled = false transactions, too
+      it.skip('creates a transaction with sampled = false if it returns undefined', () => {
         const mockBeforeNavigation = jest.fn().mockReturnValue(undefined);
         createBrowserTracing(true, {
           beforeNavigate: mockBeforeNavigation,
@@ -411,7 +412,9 @@ describe('BrowserTracing', () => {
     });
 
     describe('using the data', () => {
-      it('uses the data for pageload transactions', () => {
+      // TODO add this back in once getTransaction() returns sampled = false transactions, too
+      it.skip('uses the data for pageload transactions', () => {
+        // make sampled false here, so we can see that it's being used rather than the tracesSampleRate-dictated one
         document.head.innerHTML = `<meta name="sentry-trace" content="12312012123120121231201212312012-1121201211212012-0">`;
 
         // pageload transactions are created as part of the BrowserTracing integration's initialization

packages/tracing/test/hub.test.ts

@@ -44,10 +44,10 @@ describe('Hub', () => {
       expect(hub.getScope()?.getTransaction()).toBe(transaction);
     });
 
-    it('should find a transaction which has been set on the scope if sampled = false', () => {
+    // TODO add this back in once getTransaction() returns sampled = false transactions, too
+    it.skip('should find a transaction which has been set on the scope if sampled = false', () => {
       const hub = new Hub(new BrowserClient({ tracesSampleRate: 1 }));
-      const transaction = hub.startTransaction({ name: 'dogpark' });
-      transaction.sampled = false;
+      const transaction = hub.startTransaction({ name: 'dogpark', sampled: false });
 
       hub.configureScope(scope => {
         scope.setSpan(transaction);
@@ -384,7 +384,8 @@ describe('Hub', () => {
         expect(extractTraceparentData(headers['sentry-trace'])!.parentSampled).toBe(true);
       });
 
-      it('should propagate negative sampling decision to child transactions in XHR header', () => {
+      // TODO add this back in once getTransaction() returns sampled = false transactions, too
+      it.skip('should propagate negative sampling decision to child transactions in XHR header', () => {
         const hub = new Hub(
           new BrowserClient({
             dsn: 'https://[email protected]/1121',