Skip to content

Commit a8ca8f2

Browse files
mydeaLuca Forstner
andauthored
Apply suggestions from code review
Co-authored-by: Luca Forstner <[email protected]>
1 parent 3b5370d commit a8ca8f2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/creating-a-new-sdk.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ boundary component in React) that users can use in their app to ensure all error
4444

4545
### 1c. OPTIONAL: Component Tracking
4646

47-
Optionally, we may also track component renders and similar things. These are stretch goals, though, and do not need to
47+
Optionally, we may also track the duration of component renders and similar things. These are stretch goals, though, and do not need to
4848
be part of an MVP.
4949

5050
## 2. Server SDKs
@@ -53,7 +53,7 @@ A purely server SDK generally should cover the following things:
5353

5454
### 2a. `http.server` spans with route information
5555

56-
Most SDKs that build on top of `@sentry/node` should automatically have basic `http.server` spans emitted by
56+
Most SDKs that build on top of `@sentry/node` should automatically have basic `http.server` spans emitted for incoming requests by the
5757
`httpIntegration`. However, these spans do not contain any routing information (e.g. a `http.route` attribute). A server
5858
SDK should make sure to add route information to these spans.
5959

0 commit comments

Comments
 (0)