Use contexts to handle extra error data

Author: CPatchane

packages/integrations/src/extraerrordata.ts

@@ -47,21 +47,21 @@ export class ExtraErrorData implements Integration {
     const errorData = this._extractErrorData(hint.originalException as ExtendedError);
 
     if (errorData) {
-      let extra = {
-        ...event.extra,
+      let contexts = {
+        ...event.contexts,
       };
 
       const normalizedErrorData = normalize(errorData, this._options.depth);
       if (isPlainObject(normalizedErrorData)) {
-        extra = {
-          ...event.extra,
+        contexts = {
+          ...event.contexts,
           ...normalizedErrorData,
         };
       }
 
       return {
         ...event,
-        extra,
+        contexts,
       };
     }
 
@@ -76,7 +76,6 @@ export class ExtraErrorData implements Integration {
     // We are trying to enhance already existing event, so no harm done if it won't succeed
     try {
       const nativeKeys = ['name', 'message', 'stack', 'line', 'column', 'fileName', 'lineNumber', 'columnNumber'];
-      const name = error.name || error.constructor.name;
       const errorKeys = Object.getOwnPropertyNames(error).filter(key => nativeKeys.indexOf(key) === -1);
 
       if (errorKeys.length) {
@@ -89,9 +88,7 @@ export class ExtraErrorData implements Integration {
           // tslint:disable:no-unsafe-any
           extraErrorInfo[key] = value;
         }
-        result = {
-          [name]: extraErrorInfo,
-        };
+        result = extraErrorInfo;
       }
     } catch (oO) {
       logger.error('Unable to extract extra data from the Error object:', oO);

packages/integrations/test/extraerrordata.test.ts

@@ -19,32 +19,15 @@ describe('ExtraErrorData()', () => {
       originalException: error,
     });
 
-    expect(enhancedEvent.extra).toEqual({
-      TypeError: {
-        baz: 42,
-        foo: 'bar',
-      },
-    });
-  });
-
-  it('doesnt choke on linked errors and stringify names instead', () => {
-    const error = new TypeError('foo') as ExtendedError;
-    error.cause = new SyntaxError('bar');
-
-    const enhancedEvent = extraErrorData.enhanceEventWithErrorData(event, {
-      originalException: error,
-    });
-
-    expect(enhancedEvent.extra).toEqual({
-      TypeError: {
-        cause: 'SyntaxError: bar',
-      },
+    expect(enhancedEvent.contexts).toEqual({
+      baz: 42,
+      foo: 'bar',
     });
   });
 
   it('should not remove previous data existing in extra field', () => {
     event = {
-      extra: {
+      contexts: {
         foo: 42,
       },
     };
@@ -55,10 +38,8 @@ describe('ExtraErrorData()', () => {
       originalException: error,
     });
 
-    expect(enhancedEvent.extra).toEqual({
-      TypeError: {
-        baz: 42,
-      },
+    expect(enhancedEvent.contexts).toEqual({
+      baz: 42,
       foo: 42,
     });
   });