disable console.log in build scripts

Author: JonasBa

packages/profiling-node/scripts/check-build.js

@@ -1,3 +1,6 @@
+// This is a build scripts, so some logging is desireable as it allows
+// us to follow the code path that triggered the error.
+/* eslint-disable no-console */
 const fs = require('fs');
 const child_process = require('child_process');
 const binaries = require('./binaries.js');
@@ -7,7 +10,6 @@ function clean(err) {
 }
 
 function recompileFromSource() {
-  // eslint-disable-next-line no-console
   console.log('@sentry/profiling-node: Compiling from source...');
   let spawn = child_process.spawnSync('npm', ['run', 'build:bindings:configure'], {
     stdio: ['inherit', 'inherit', 'pipe'],
@@ -16,9 +18,7 @@ function recompileFromSource() {
   });
 
   if (spawn.status !== 0) {
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node: Failed to configure gyp');
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node:', clean(spawn.stderr));
     return;
   }
@@ -29,36 +29,28 @@ function recompileFromSource() {
     shell: true,
   });
   if (spawn.status !== 0) {
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node: Failed to build bindings');
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node:', clean(spawn.stderr));
     return;
   }
 }
 
 if (fs.existsSync(binaries.target)) {
   try {
-    // eslint-disable-next-line no-console
     console.log(`@sentry/profiling-node: Precompiled binary found, attempting to load ${binaries.target}`);
     require(binaries.target);
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node: Precompiled binary found, skipping build from source.');
   } catch (e) {
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node: Precompiled binary found but failed loading');
-    // eslint-disable-next-line no-console
     console.log('@sentry/profiling-node:', e);
     try {
       recompileFromSource();
     } catch (e) {
-      // eslint-disable-next-line no-console
       console.log('@sentry/profiling-node: Failed to compile from source');
       throw e;
     }
   }
 } else {
-  // eslint-disable-next-line no-console
   console.log('@sentry/profiling-node: No precompiled binary found');
   recompileFromSource();
 }

packages/profiling-node/scripts/copy-target.js

@@ -1,3 +1,6 @@
+// This is a build scripts, so some logging is desireable as it allows
+// us to follow the code path that triggered the error.
+/* eslint-disable no-console */
 const fs = require('fs');
 const path = require('path');
 const process = require('process');
@@ -13,15 +16,12 @@ const source = path.join(__dirname, '..', 'build', 'Release', 'sentry_cpu_profil
 const target = path.join(__dirname, '..', 'lib', binaries.getModuleName());
 
 if (!fs.existsSync(source)) {
-  // eslint-disable-next-line no-console
   console.log('Source file does not exist:', source);
   process.exit(1);
 } else {
   if (fs.existsSync(target)) {
-    // eslint-disable-next-line no-console
     console.log('Target file already exists, overwriting it');
   }
-  // eslint-disable-next-line no-console
   console.log('Renaming', source, 'to', target);
   fs.renameSync(source, target);
 }

packages/profiling-node/scripts/prune-profiler-binaries.js

@@ -1,4 +1,8 @@
 #! /usr/bin/env node
+
+// This is a build scripts, so some logging is desireable as it allows
+// us to follow the code path that triggered the error.
+/* eslint-disable no-console */
 const fs = require('fs');
 
 let SOURCE_DIR, PLATFORM, ARCH, STDLIB, NODE, HELP;
@@ -37,7 +41,6 @@ for (let i = 0; i < process.argv.length; i++) {
 }
 
 if (HELP) {
-  // eslint-disable-next-line no-console
   console.log(
     `\nSentry: Prune profiler binaries\n
 Usage: sentry-prune-profiler-binaries --target_dir_path=... --target_platform=... --target_arch=... --target_stdlib=...\n
@@ -91,7 +94,6 @@ If you are unsure about the execution environment, you can opt to skip some valu
 }
 
 if (ARGV_ERRORS.length > 0) {
-  // eslint-disable-next-line no-console
   console.log(ARGV_ERRORS.join('\n'));
   process.exit(1);
 }
@@ -150,26 +152,22 @@ async function prune(binaries) {
     removedBinariesCount++;
 
     if (process.argv.includes('--dry-run')) {
-      // eslint-disable-next-line no-console
       console.log(`Sentry: would have pruned ${binary} (${bytesToHumanReadable(stats.size)})`);
       continue;
     }
 
-    // eslint-disable-next-line no-console
     console.log(`Sentry: pruned ${binary} (${bytesToHumanReadable(stats.size)})`);
     fs.unlinkSync(binary);
   }
 
   if (removedBinariesCount === 0) {
-    // eslint-disable-next-line no-console
     console.log(
       '❌ Sentry: no binaries pruned, please make sure target argument values are valid or use --help for more information.',
     );
     return;
   }
 
   if (process.argv.includes('--dry-run')) {
-    // eslint-disable-next-line no-console
     console.log(
       `✅ Sentry: would have pruned ${removedBinariesCount} ${
         removedBinariesCount === 1 ? 'binary' : 'binaries'
@@ -178,7 +176,6 @@ async function prune(binaries) {
     return;
   }
 
-  // eslint-disable-next-line no-console
   console.log(
     `✅ Sentry: pruned ${removedBinariesCount} ${
       removedBinariesCount === 1 ? 'binary' : 'binaries'