ci: Re-add size limit action

add description

reorder stuff

use old version of artifacts

fix dirname

fix

bump node version

fix cwd?

skip nextjs for now

update limits

better log?

fix trim it

fix size limit creation

really fix command?

Author: mydea

.github/workflows/build.yml

@@ -278,6 +278,34 @@ jobs:
       # `job_build` can't see `job_install_deps` and what it returned)
       dependency_cache_key: ${{ needs.job_install_deps.outputs.dependency_cache_key }}
 
+  job_size_check:
+    name: Size Check
+    needs: [job_get_metadata, job_build]
+    timeout-minutes: 15
+    runs-on: ubuntu-20.04
+    if:
+      github.event_name == 'pull_request' || needs.job_get_metadata.outputs.is_develop == 'true' ||
+      needs.job_get_metadata.outputs.is_release == 'true'
+    steps:
+      - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ env.HEAD_COMMIT }}
+      - name: Set up Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: 'package.json'
+      - name: Restore caches
+        uses: ./.github/actions/restore-cache
+        env:
+          DEPENDENCY_CACHE_KEY: ${{ needs.job_build.outputs.dependency_cache_key }}
+      - name: Check bundle sizes
+        uses: ./dev-packages/size-limit-gh-action
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          # Only run comparison against develop if this is a PR
+          comparison_branch: ${{ (github.event_name == 'pull_request' && github.base_ref) ||  ''}}
+
   job_lint:
     name: Lint
     # Even though the linter only checks source code, not built code, it needs the built code in order check that all

.size-limit.js

@@ -45,21 +45,21 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: '{ init, browserTracingIntegration }',
     gzip: true,
-    limit: '35 KB',
+    limit: '90 KB',
   },
   {
     name: '@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped)',
     path: 'packages/browser/build/npm/esm/index.js',
     import: '{ init, browserTracingIntegration }',
     gzip: true,
-    limit: '35 KB',
+    limit: '90 KB',
   },
   {
     name: '@sentry/browser (incl. feedbackIntegration) - Webpack (gzipped)',
     path: 'packages/browser/build/npm/esm/index.js',
     import: '{ init, feedbackIntegration }',
     gzip: true,
-    limit: '50 KB',
+    limit: '90 KB',
   },
   {
     name: '@sentry/browser (incl. feedbackModalIntegration) - Webpack (gzipped)',
@@ -80,14 +80,14 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/index.js',
     import: '{ init, sendFeedback }',
     gzip: true,
-    limit: '50 KB',
+    limit: '90 KB',
   },
   {
     name: '@sentry/browser - Webpack (gzipped)',
     path: 'packages/browser/build/npm/esm/index.js',
     import: '{ init }',
     gzip: true,
-    limit: '28 KB',
+    limit: '90 KB',
   },
 
   // Browser CDN bundles
@@ -107,13 +107,13 @@ module.exports = [
     name: '@sentry/browser (incl. Tracing) - CDN Bundle (gzipped)',
     path: 'packages/browser/build/bundles/bundle.tracing.min.js',
     gzip: true,
-    limit: '37 KB',
+    limit: '40 KB',
   },
   {
     name: '@sentry/browser - CDN Bundle (gzipped)',
     path: 'packages/browser/build/bundles/bundle.min.js',
     gzip: true,
-    limit: '28 KB',
+    limit: '30 KB',
   },
 
   // browser CDN bundles (non-gzipped)
@@ -129,7 +129,7 @@ module.exports = [
     path: 'packages/browser/build/bundles/bundle.tracing.min.js',
     gzip: false,
     brotli: false,
-    limit: '105 KB',
+    limit: '120 KB',
   },
   {
     name: '@sentry/browser - CDN Bundle (minified & uncompressed)',
@@ -145,18 +145,19 @@ module.exports = [
     path: 'packages/react/build/esm/index.js',
     import: '{ init, browserTracingIntegration, replayIntegration }',
     gzip: true,
-    limit: '75 KB',
+    limit: '90 KB',
   },
   {
     name: '@sentry/react - Webpack (gzipped)',
     path: 'packages/react/build/esm/index.js',
     import: '{ init }',
     gzip: true,
-    limit: '30 KB',
+    limit: '90 KB',
   },
 
   // Next.js
-  {
+  // TODO: Re-enable these, when we figure out why they break...
+  /*  {
     name: '@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)',
     path: 'packages/nextjs/build/esm/client/index.js',
     import: '{ init, browserTracingIntegration, replayIntegration }',
@@ -169,12 +170,5 @@ module.exports = [
     import: '{ init }',
     gzip: true,
     limit: '57 KB',
-  },
-  {
-    name: '@sentry-internal/feedback - Webpack (gzipped)',
-    path: 'packages/feedback/build/npm/esm/index.js',
-    import: '{ feedbackIntegration }',
-    gzip: true,
-    limit: '25 KB',
-  },
+  }, */
 ];

dev-packages/size-limit-gh-action/.eslintrc.cjs

@@ -0,0 +1,14 @@
+module.exports = {
+  extends: ['../../.eslintrc.js'],
+  parserOptions: {
+    sourceType: 'module',
+    ecmaVersion: 'latest',
+  },
+
+  overrides: [
+    {
+      files: ['*.mjs'],
+      extends: ['@sentry-internal/sdk/src/base'],
+    },
+  ],
+};

dev-packages/size-limit-gh-action/action.yml

@@ -0,0 +1,17 @@
+name: 'size-limit-gh-action'
+description: 'Run size-limit comparison'
+inputs:
+  github_token:
+    required: true
+    description: 'a github access token'
+  comparison_branch:
+    required: false
+    default: ""
+    description: "If set, compare the current branch with this branch"
+  threshold:
+    required: false
+    default: "0.0125"
+    description: "The percentage threshold for size changes before posting a comment"
+runs:
+  using: 'node20'
+  main: 'index.mjs'