WIP debugging stuff???

Author: mydea

dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx

@@ -38,7 +38,7 @@ Sentry.init({
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 0.0,
 
-  debug: !!process.env.DEBUG,
+  debug: true,
 });
 
 const sentryCreateHashRouter = Sentry.wrapCreateBrowserRouter(createHashRouter);

dev-packages/e2e-tests/test-applications/react-create-hash-router/tests/transactions.test.ts

@@ -6,11 +6,13 @@ test('Captures a pageload transaction', async ({ page }) => {
     return event.contexts?.trace?.op === 'pageload';
   });
 
+  page.on('console', msg => console.log(msg.text()));
+
   await page.goto('/');
 
   const transactionEvent = await transactionEventPromise;
   expect(transactionEvent.contexts?.trace).toEqual({
-    data: expect.objectContaining({
+    data: {
       deviceMemory: expect.any(String),
       effectiveConnectionType: expect.any(String),
       hardwareConcurrency: expect.any(String),
@@ -19,7 +21,7 @@ test('Captures a pageload transaction', async ({ page }) => {
       'sentry.origin': 'auto.pageload.react.reactrouter_v6',
       'sentry.sample_rate': 1,
       'sentry.source': 'route',
-    }),
+    },
     op: 'pageload',
     span_id: expect.any(String),
     trace_id: expect.any(String),

packages/browser-utils/src/metrics/utils.ts

@@ -1,6 +1,8 @@
 import type { SentrySpan } from '@sentry/core';
 import { spanToJSON, startInactiveSpan, withActiveSpan } from '@sentry/core';
 import type { Span, SpanTimeInput, StartSpanOptions } from '@sentry/types';
+import { logger } from '@sentry/utils';
+import { DEBUG_BUILD } from '../debug-build';
 import { WINDOW } from '../types';
 
 /**
@@ -20,12 +22,13 @@ export function startAndEndSpan(
   startTimeInSeconds: number,
   endTime: SpanTimeInput,
   { ...ctx }: StartSpanOptions,
-): Span | undefined {
+): Span {
   const parentStartTime = spanToJSON(parentSpan).start_timestamp;
   if (parentStartTime && parentStartTime > startTimeInSeconds) {
     // We can only do this for SentrySpans...
     if (typeof (parentSpan as Partial<SentrySpan>).updateStartTime === 'function') {
       (parentSpan as SentrySpan).updateStartTime(startTimeInSeconds);
+      DEBUG_BUILD && logger.log('Updated parent span start to start of child span.', ctx);
     }
   }
 
@@ -36,9 +39,7 @@ export function startAndEndSpan(
       ...ctx,
     });
 
-    if (span) {
-      span.end(endTime);
-    }
+    span.end(endTime);
 
     return span;
   });