fix(types): Add AttachmentType and use for envelope attachment_type property (#10946)

`Attachment.attachmentType` was changed to use a string union. The
`attachment_type` header property should match so I added an extra type
for this.

Author: timfish

packages/core/test/lib/transports/base.test.ts

@@ -23,7 +23,7 @@ const ATTACHMENT_ENVELOPE = createEnvelope<EventEnvelope>(
         length: 20,
         filename: 'test-file.txt',
         content_type: 'text/plain',
-        attachment_type: 'text',
+        attachment_type: 'event.attachment',
       },
       'attachment content',
     ] as AttachmentItem,

packages/types/src/attachment.ts

@@ -1,6 +1,23 @@
+export type AttachmentType =
+  | 'event.attachment'
+  | 'event.minidump'
+  | 'event.applecrashreport'
+  | 'unreal.context'
+  | 'unreal.logs';
+
+/**
+ * An attachment to an event. This is used to upload arbitrary data to Sentry.
+ *
+ * Please take care to not add sensitive information in attachments.
+ *
+ * https://develop.sentry.dev/sdk/envelopes/#attachment
+ */
 export interface Attachment {
   data: string | Uint8Array;
   filename: string;
   contentType?: string;
-  attachmentType?: string;
+  /**
+   * The type of the attachment. Defaults to `event.attachment` if not specified.
+   */
+  attachmentType?: AttachmentType;
 }

packages/types/src/envelope.ts

@@ -1,3 +1,4 @@
+import type { AttachmentType } from './attachment';
 import type { SerializedCheckIn } from './checkin';
 import type { ClientReport } from './clientreport';
 import type { DsnComponents } from './dsn';
@@ -72,7 +73,7 @@ type AttachmentItemHeaders = {
   length: number;
   filename: string;
   content_type?: string;
-  attachment_type?: string;
+  attachment_type?: AttachmentType;
 };
 type UserFeedbackItemHeaders = { type: 'user_report' };
 type FeedbackItemHeaders = { type: 'feedback' };