chore(biome): enable noUnusedImports rule

AbhiPrasad · AbhiPrasad · commit 9ac07a48a851 · 2023-12-18T11:52:35.000-05:00
diff --git a/biome.json b/biome.json
@@ -20,6 +20,9 @@
       "suspicious": {
         "all": false,
         "noControlCharactersInRegex": "error"
+      },
+      "nursery": {
+        "noUnusedImports": "error"
       }
     },
     "ignore": [".vscode/*", "**/*.json"]
diff --git a/packages/angular/test/tracing.test.ts b/packages/angular/test/tracing.test.ts
@@ -1,6 +1,5 @@
 import { Component } from '@angular/core';
 import type { ActivatedRouteSnapshot, CanActivate, RouterStateSnapshot } from '@angular/router';
-import type { Hub } from '@sentry/types';
 
 import { TraceClassDecorator, TraceDirective, TraceMethodDecorator, instrumentAngularRouting } from '../src';
 import { getParameterizedRouteFromSnapshot } from '../src/tracing';
diff --git a/packages/astro/test/server/middleware.test.ts b/packages/astro/test/server/middleware.test.ts
@@ -1,6 +1,6 @@
 import * as SentryNode from '@sentry/node';
 import type { Client } from '@sentry/types';
-import { SpyInstance, vi } from 'vitest';
+import { vi } from 'vitest';
 
 import { handleRequest, interpolateRouteFromUrlAndParams } from '../../src/server/middleware';
 
diff --git a/packages/browser-integration-tests/suites/public-api/startTransaction/init.js b/packages/browser-integration-tests/suites/public-api/startTransaction/init.js
@@ -1,6 +1,5 @@
 import * as Sentry from '@sentry/browser';
-// eslint-disable-next-line no-unused-vars
-import * as _ from '@sentry/tracing';
+import '@sentry/tracing';
 
 window.Sentry = Sentry;
 
diff --git a/packages/core/src/metrics/utils.ts b/packages/core/src/metrics/utils.ts
@@ -1,6 +1,6 @@
 import type { MeasurementUnit, MetricBucketItem } from '@sentry/types';
 import { dropUndefinedKeys } from '@sentry/utils';
-import type { MetricType, SimpleMetricBucket } from './types';
+import type { MetricType } from './types';
 
 /**
  * Generate bucket key from metric properties.
diff --git a/packages/deno/src/integrations/deno-cron.ts b/packages/deno/src/integrations/deno-cron.ts
@@ -1,6 +1,5 @@
 import { withMonitor } from '@sentry/core';
 import type { Integration } from '@sentry/types';
-import type { DenoClient } from '../client';
 import { parseScheduleToString } from './deno-cron-format';
 
 type CronOptions = { backoffSchedule?: number[]; signal?: AbortSignal };
diff --git a/packages/deno/src/integrations/globalhandlers.ts b/packages/deno/src/integrations/globalhandlers.ts
@@ -1,5 +1,5 @@
 import type { ServerRuntimeClient } from '@sentry/core';
-import { getClient, getCurrentHub, getCurrentScope } from '@sentry/core';
+import { getClient, getCurrentHub } from '@sentry/core';
 import { flush } from '@sentry/core';
 import type { Event, Hub, Integration, Primitive, StackParser } from '@sentry/types';
 import { eventFromUnknownInput, isPrimitive } from '@sentry/utils';
diff --git a/packages/e2e-tests/test-applications/create-remix-app-v2/app/entry.server.tsx b/packages/e2e-tests/test-applications/create-remix-app-v2/app/entry.server.tsx
@@ -6,7 +6,7 @@
 
 import { PassThrough } from 'node:stream';
 
-import type { AppLoadContext, DataFunctionArgs, EntryContext } from '@remix-run/node';
+import type { AppLoadContext, EntryContext } from '@remix-run/node';
 import { createReadableStreamFromReadable } from '@remix-run/node';
 import { installGlobals } from '@remix-run/node';
 import { RemixServer } from '@remix-run/react';
diff --git a/packages/e2e-tests/test-applications/create-remix-app/app/entry.server.tsx b/packages/e2e-tests/test-applications/create-remix-app/app/entry.server.tsx
@@ -6,7 +6,7 @@
 
 import { PassThrough } from 'node:stream';
 
-import type { AppLoadContext, DataFunctionArgs, EntryContext } from '@remix-run/node';
+import type { AppLoadContext, EntryContext } from '@remix-run/node';
 import { Response } from '@remix-run/node';
 import { RemixServer } from '@remix-run/react';
 import * as Sentry from '@sentry/remix';
diff --git a/packages/e2e-tests/test-applications/generic-ts3.8/index.ts b/packages/e2e-tests/test-applications/generic-ts3.8/index.ts
@@ -1,13 +1,2 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
 // we need to import the SDK to ensure tsc check the types
-import * as _SentryBrowser from '@sentry/browser';
-import * as _SentryCore from '@sentry/core';
-import * as _SentryHub from '@sentry/hub';
-import * as _SentryIntegrations from '@sentry/integrations';
-import * as _SentryNode from '@sentry/node';
-import * as _SentryOpentelemetry from '@sentry/opentelemetry-node';
-import * as _SentryReplay from '@sentry/replay';
-import * as _SentryTracing from '@sentry/tracing';
-import * as _SentryTypes from '@sentry/types';
-import * as _SentryUtils from '@sentry/utils';
-import * as _SentryWasm from '@sentry/wasm';
diff --git a/packages/e2e-tests/test-applications/nextjs-app-dir/tests/async-context-edge.test.ts b/packages/e2e-tests/test-applications/nextjs-app-dir/tests/async-context-edge.test.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import { waitForError, waitForTransaction } from '../event-proxy-server';
+import { waitForTransaction } from '../event-proxy-server';
 
 test('Should allow for async context isolation in the edge SDK', async ({ request }) => {
   // test.skip(process.env.TEST_ENV === 'development', "Doesn't work in dev mode.");
diff --git a/packages/e2e-tests/test-applications/node-hapi-app/tests/server.test.ts b/packages/e2e-tests/test-applications/node-hapi-app/tests/server.test.ts
@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import axios, { AxiosError, AxiosResponse } from 'axios';
+import axios, { AxiosError } from 'axios';
 import { waitForError, waitForTransaction } from '../event-proxy-server';
 
 const authToken = process.env.E2E_TEST_AUTH_TOKEN;
diff --git a/packages/e2e-tests/test-applications/react-create-hash-router/src/pages/Index.tsx b/packages/e2e-tests/test-applications/react-create-hash-router/src/pages/Index.tsx
@@ -1,5 +1,6 @@
 import * as Sentry from '@sentry/react';
-import * as React from 'react';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
+import  * as React from 'react';
 import { Link } from 'react-router-dom';
 
 const Index = () => {
diff --git a/packages/e2e-tests/test-applications/react-create-hash-router/src/pages/User.tsx b/packages/e2e-tests/test-applications/react-create-hash-router/src/pages/User.tsx
@@ -1,3 +1,4 @@
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 
 const User = () => {
diff --git a/packages/e2e-tests/test-applications/react-router-6-use-routes/src/pages/Index.tsx b/packages/e2e-tests/test-applications/react-router-6-use-routes/src/pages/Index.tsx
@@ -1,4 +1,5 @@
 import * as Sentry from '@sentry/react';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 import { Link } from 'react-router-dom';
 
diff --git a/packages/e2e-tests/test-applications/react-router-6-use-routes/src/pages/User.tsx b/packages/e2e-tests/test-applications/react-router-6-use-routes/src/pages/User.tsx
@@ -1,3 +1,4 @@
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 
 const User = () => {
diff --git a/packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/src/pages/Index.tsx b/packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/src/pages/Index.tsx
@@ -1,4 +1,5 @@
 import * as Sentry from '@sentry/react';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 import { Link } from 'react-router-dom';
 
diff --git a/packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/src/pages/User.tsx b/packages/e2e-tests/test-applications/standard-frontend-react-tracing-import/src/pages/User.tsx
@@ -1,3 +1,4 @@
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 
 const User = () => {
diff --git a/packages/e2e-tests/test-applications/standard-frontend-react/src/pages/Index.tsx b/packages/e2e-tests/test-applications/standard-frontend-react/src/pages/Index.tsx
@@ -1,4 +1,5 @@
 import * as Sentry from '@sentry/react';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 import { Link } from 'react-router-dom';
 
diff --git a/packages/e2e-tests/test-applications/standard-frontend-react/src/pages/User.tsx b/packages/e2e-tests/test-applications/standard-frontend-react/src/pages/User.tsx
@@ -1,3 +1,4 @@
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 
 const User = () => {
diff --git a/packages/gatsby/test/integration.test.tsx b/packages/gatsby/test/integration.test.tsx
@@ -2,7 +2,7 @@ import { TextDecoder, TextEncoder } from 'util';
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import { render } from '@testing-library/react';
 import { useEffect } from 'react';
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 
 import { onClientEntry } from '../gatsby-browser';
diff --git a/packages/nextjs/src/common/_error.ts b/packages/nextjs/src/common/_error.ts
@@ -1,4 +1,4 @@
-import { captureException, getClient, withScope } from '@sentry/core';
+import { captureException, withScope } from '@sentry/core';
 import type { NextPageContext } from 'next';
 import { flushQueue } from './utils/responseEnd';
 
diff --git a/packages/nextjs/src/config/templates/routeHandlerWrapperTemplate.ts b/packages/nextjs/src/config/templates/routeHandlerWrapperTemplate.ts
@@ -2,8 +2,10 @@ import * as Sentry from '@sentry/nextjs';
 import type { WebFetchHeaders } from '@sentry/types';
 // @ts-expect-error Because we cannot be sure if the RequestAsyncStorage module exists (it is not part of the Next.js public
 // API) we use a shim if it doesn't exist. The logic for this is in the wrapping loader.
+// biome-ignore lint/nursery/noUnusedImports: Biome doesn't understand the shim with variable import path
 import { requestAsyncStorage } from '__SENTRY_NEXTJS_REQUEST_ASYNC_STORAGE_SHIM__';
 // @ts-expect-error See above
+// biome-ignore lint/nursery/noUnusedImports: Biome doesn't understand the shim with variable import path
 import * as routeModule from '__SENTRY_WRAPPING_TARGET_FILE__';
 
 import type { RequestAsyncStorage } from './requestAsyncStorageShim';
diff --git a/packages/nextjs/src/config/templates/serverComponentWrapperTemplate.ts b/packages/nextjs/src/config/templates/serverComponentWrapperTemplate.ts
@@ -2,8 +2,10 @@ import * as Sentry from '@sentry/nextjs';
 import type { WebFetchHeaders } from '@sentry/types';
 // @ts-expect-error Because we cannot be sure if the RequestAsyncStorage module exists (it is not part of the Next.js public
 // API) we use a shim if it doesn't exist. The logic for this is in the wrapping loader.
+// biome-ignore lint/nursery/noUnusedImports: Biome doesn't understand the shim with variable import path
 import { requestAsyncStorage } from '__SENTRY_NEXTJS_REQUEST_ASYNC_STORAGE_SHIM__';
 // @ts-expect-error We use `__SENTRY_WRAPPING_TARGET_FILE__` as a placeholder for the path to the file being wrapped.
+// biome-ignore lint/nursery/noUnusedImports: Biome doesn't understand the shim with variable import path
 import * as serverComponentModule from '__SENTRY_WRAPPING_TARGET_FILE__';
 
 import type { RequestAsyncStorage } from './requestAsyncStorageShim';
diff --git a/packages/nextjs/src/edge/wrapApiHandlerWithSentry.ts b/packages/nextjs/src/edge/wrapApiHandlerWithSentry.ts
@@ -1,4 +1,4 @@
-import { getCurrentHub, getCurrentScope } from '@sentry/core';
+import { getCurrentScope } from '@sentry/core';
 
 import { withEdgeWrapping } from '../common/utils/edgeWrapperUtils';
 import type { EdgeRouteHandler } from './types';
diff --git a/packages/nextjs/test/integration/components/Layout.tsx b/packages/nextjs/test/integration/components/Layout.tsx
@@ -1,6 +1,6 @@
 import Head from 'next/head';
 import Link from 'next/link';
-import React, { ReactNode } from 'react';
+import { ReactNode } from 'react';
 
 type Props = {
   children?: ReactNode;
diff --git a/packages/nextjs/test/integration/components/List.tsx b/packages/nextjs/test/integration/components/List.tsx
@@ -1,3 +1,4 @@
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 import { User } from '../interfaces';
 import ListItem from './ListItem';
diff --git a/packages/nextjs/test/integration/components/ListDetail.tsx b/packages/nextjs/test/integration/components/ListDetail.tsx
@@ -1,3 +1,4 @@
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 
 import { User } from '../interfaces';
diff --git a/packages/nextjs/test/integration/components/ListItem.tsx b/packages/nextjs/test/integration/components/ListItem.tsx
@@ -1,4 +1,5 @@
 import Link from 'next/link';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import React from 'react';
 
 import { User } from '../interfaces';
diff --git a/packages/node-experimental/src/integrations/http.ts b/packages/node-experimental/src/integrations/http.ts
@@ -4,7 +4,7 @@ import { SpanKind } from '@opentelemetry/api';
 import { registerInstrumentations } from '@opentelemetry/instrumentation';
 import { HttpInstrumentation } from '@opentelemetry/instrumentation-http';
 import { addBreadcrumb, hasTracingEnabled, isSentryRequestUrl } from '@sentry/core';
-import { _INTERNAL, getClient, getCurrentHub, getSpanKind, setSpanMetadata } from '@sentry/opentelemetry';
+import { _INTERNAL, getClient, getSpanKind, setSpanMetadata } from '@sentry/opentelemetry';
 import type { EventProcessor, Hub, Integration } from '@sentry/types';
 import { stringMatchesSomePattern } from '@sentry/utils';
 
diff --git a/packages/react/test/profiler.test.tsx b/packages/react/test/profiler.test.tsx
@@ -1,6 +1,7 @@
 import type { SpanContext } from '@sentry/types';
 import { render } from '@testing-library/react';
 import { renderHook } from '@testing-library/react-hooks';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSXq
 import * as React from 'react';
 
 import { REACT_MOUNT_OP, REACT_RENDER_OP, REACT_UPDATE_OP } from '../src/constants';
diff --git a/packages/react/test/reactrouterv4.test.tsx b/packages/react/test/reactrouterv4.test.tsx
@@ -1,5 +1,6 @@
 import { act, render } from '@testing-library/react';
 import { createMemoryHistory } from 'history-4';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 import { Route, Router, Switch, matchPath } from 'react-router-4';
 
diff --git a/packages/react/test/reactrouterv5.test.tsx b/packages/react/test/reactrouterv5.test.tsx
@@ -1,5 +1,6 @@
 import { act, render } from '@testing-library/react';
 import { createMemoryHistory } from 'history-4';
+// biome-ignore lint/nursery/noUnusedImports: Need React import for JSX
 import * as React from 'react';
 import { Route, Router, Switch, matchPath } from 'react-router-5';
 
diff --git a/packages/react/test/redux.test.ts b/packages/react/test/redux.test.ts
@@ -1,5 +1,4 @@
 import * as Sentry from '@sentry/browser';
-import type { Scope } from '@sentry/types';
 import * as Redux from 'redux';
 
 import { createReduxEnhancer } from '../src/redux';
diff --git a/packages/remix/test/integration/app_v2/entry.server.tsx b/packages/remix/test/integration/app_v2/entry.server.tsx
@@ -1,4 +1,4 @@
-import type { DataFunctionArgs, EntryContext } from '@remix-run/node';
+import type { EntryContext } from '@remix-run/node';
 import { RemixServer } from '@remix-run/react';
 import * as Sentry from '@sentry/remix';
 import { renderToString } from 'react-dom/server';
diff --git a/packages/remix/test/integration/common/routes/server-side-unexpected-errors.$id.tsx b/packages/remix/test/integration/common/routes/server-side-unexpected-errors.$id.tsx
@@ -1,4 +1,4 @@
-import { ActionFunction, LoaderFunction, json, redirect } from '@remix-run/node';
+import { ActionFunction } from '@remix-run/node';
 import { useActionData } from '@remix-run/react';
 
 export const action: ActionFunction = async ({ params: { id } }) => {
diff --git a/packages/vue/src/tracing.ts b/packages/vue/src/tracing.ts
@@ -1,4 +1,4 @@
-import { getCurrentHub, getCurrentScope } from '@sentry/browser';
+import { getCurrentScope } from '@sentry/browser';
 import type { Span, Transaction } from '@sentry/types';
 import { logger, timestampInSeconds } from '@sentry/utils';
 
