Skip to content

Commit 98aaecb

Browse files
committed
Fix typing around passing config at runtime, so that all options are included instead of special casing transport
1 parent 2b7134d commit 98aaecb

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

packages/ember/addon/index.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
import * as Sentry from '@sentry/browser';
2-
import { addGlobalEventProcessor, SDK_VERSION } from '@sentry/browser';
3-
import { Transport } from '@sentry/types';
2+
import { addGlobalEventProcessor, SDK_VERSION, BrowserOptions } from '@sentry/browser';
43
import environmentConfig from 'ember-get-config';
54

65
import { next } from '@ember/runloop';
76
import { assert, warn, runInDebug } from '@ember/debug';
87
import Ember from 'ember';
98

10-
export function SentryForEmber(_runtimeConfigOverride: { transport?: Transport } | undefined) {
9+
export function SentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
1110
const config = environmentConfig['@sentry/ember'];
1211
assert('Missing configuration', config);
1312
assert('Missing configuration for Sentry.', config.sentry);
1413

15-
const initConfig = Object.assign({}, config.sentry, _runtimeConfigOverride || {});
14+
const initConfig = Object.assign({}, config.sentry, _runtimeConfig || {});
1615

1716
createEmberEventProcessor();
1817

0 commit comments

Comments
 (0)