fix: run lint

Author: JonasBa

.github/workflows/build.yml

@@ -403,6 +403,7 @@ jobs:
     name: Profiling Node Unit Tests
     needs: [job_get_metadata, job_build]
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
       - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
         uses: actions/checkout@v4
@@ -1061,6 +1062,7 @@ jobs:
     needs: [job_get_metadata, job_build]
     runs-on: ${{ matrix.os }}
     container: ${{ matrix.container }}
+    timeout-minutes: 10
     strategy:
       fail-fast: false
       matrix:

packages/profiling-node/bindings/cpu_profiler.cc

@@ -12,13 +12,13 @@
 #include <unordered_map>
 
 static const uint8_t kMaxStackDepth(128);
-static const float kSamplingFrequency(99.0);  // 99 to avoid lockstep sampling
+static const float kSamplingFrequency(99.0); // 99 to avoid lockstep sampling
 static const float kSamplingHz(1 / kSamplingFrequency);
 static const int kSamplingInterval(kSamplingHz * 1e6);
-static const v8::CpuProfilingNamingMode kNamingMode(
-    v8::CpuProfilingNamingMode::kDebugNaming);
-static const v8::CpuProfilingLoggingMode kDefaultLoggingMode(
-    v8::CpuProfilingLoggingMode::kEagerLogging);
+static const v8::CpuProfilingNamingMode
+    kNamingMode(v8::CpuProfilingNamingMode::kDebugNaming);
+static const v8::CpuProfilingLoggingMode
+    kDefaultLoggingMode(v8::CpuProfilingLoggingMode::kEagerLogging);
 
 // Allow users to override the default logging mode via env variable. This is
 // useful because sometimes the flow of the profiled program can be to execute
@@ -57,7 +57,7 @@ enum class ProfileStatus {
 };
 
 class MeasurementsTicker {
- private:
+private:
   uv_timer_t timer;
   uint64_t period_ms;
   std::unordered_map<std::string,
@@ -69,7 +69,7 @@ class MeasurementsTicker {
   v8::HeapStatistics heap_stats;
   uv_cpu_info_t cpu_stats;
 
- public:
+public:
   MeasurementsTicker(uv_loop_t *loop)
       : period_ms(100), isolate(v8::Isolate::GetCurrent()) {
     uv_timer_init(loop, &timer);
@@ -218,7 +218,7 @@ void MeasurementsTicker::remove_cpu_listener(
 };
 
 class Profiler {
- public:
+public:
   std::unordered_map<std::string, SentryProfile *> active_profiles;
 
   MeasurementsTicker measurements_ticker;
@@ -231,7 +231,7 @@ class Profiler {
 };
 
 class SentryProfile {
- private:
+private:
   uint64_t started_at;
   uint16_t heap_write_index = 0;
   uint16_t cpu_write_index = 0;
@@ -248,7 +248,7 @@ class SentryProfile {
   ProfileStatus status = ProfileStatus::kNotStarted;
   std::string id;
 
- public:
+public:
   explicit SentryProfile(const char *id)
       : started_at(uv_hrtime()),
         memory_sampler_cb([this](uint64_t ts, v8::HeapStatistics &stats) {
@@ -280,8 +280,7 @@ class SentryProfile {
           return false;
         }),
 
-        status(ProfileStatus::kNotStarted),
-        id(id) {
+        status(ProfileStatus::kNotStarted), id(id) {
     heap_stats_ts.reserve(300);
     heap_stats_usage.reserve(300);
     cpu_stats_ts.reserve(300);
@@ -453,10 +452,10 @@ static napi_value GetFrameModuleWrapped(napi_env env, napi_callback_info info) {
   return napi_module;
 }
 
-napi_value CreateFrameNode(
-    const napi_env &env, const v8::CpuProfileNode &node,
-    std::unordered_map<std::string, std::string> &module_cache,
-    napi_value &resources) {
+napi_value
+CreateFrameNode(const napi_env &env, const v8::CpuProfileNode &node,
+                std::unordered_map<std::string, std::string> &module_cache,
+                napi_value &resources) {
   napi_value js_node;
   napi_create_object(env, &js_node);
 
@@ -664,10 +663,11 @@ static void GetSamples(const napi_env &env, const v8::CpuProfile *profile,
   }
 }
 
-static napi_value TranslateMeasurementsDouble(
-    const napi_env &env, const char *unit, const uint16_t size,
-    const std::vector<double> &values,
-    const std::vector<uint64_t> &timestamps) {
+static napi_value
+TranslateMeasurementsDouble(const napi_env &env, const char *unit,
+                            const uint16_t size,
+                            const std::vector<double> &values,
+                            const std::vector<uint64_t> &timestamps) {
   if (size > values.size() || size > timestamps.size()) {
     napi_throw_range_error(env, "NAPI_ERROR",
                            "CPU measurement size is larger than the number of "
@@ -718,10 +718,10 @@ static napi_value TranslateMeasurementsDouble(
   return measurement;
 }
 
-static napi_value TranslateMeasurements(
-    const napi_env &env, const char *unit, const uint16_t size,
-    const std::vector<uint64_t> &values,
-    const std::vector<uint64_t> &timestamps) {
+static napi_value
+TranslateMeasurements(const napi_env &env, const char *unit,
+                      const uint16_t size, const std::vector<uint64_t> &values,
+                      const std::vector<uint64_t> &timestamps) {
   if (size > values.size() || size > timestamps.size()) {
     napi_throw_range_error(env, "NAPI_ERROR",
                            "Memory measurement size is larger than the number "

packages/profiling-node/clang-format.js

@@ -0,0 +1,20 @@
+const child_process = require('child_process');
+
+const args = ['--Werror', '-i', '--style=file', 'bindings/cpu_profiler.cc'];
+const cmd = `./node_modules/.bin/clang-format ${args.join(' ')}`;
+
+child_process.execSync(cmd);
+
+// eslint-disable-next-line no-console
+console.log('clang-format: done, checking tree...');
+
+const diff = child_process.execSync('git status --short').toString();
+
+if (diff) {
+  // eslint-disable-next-line no-console
+  console.error('clang-format: check failed ❌');
+  process.exit(1);
+}
+
+// eslint-disable-next-line no-console
+console.log('clang-format: check passed ✅');

packages/profiling-node/clang-format.mjs

@@ -160,6 +160,7 @@ export function __PRIVATE__wrapStartTransactionWithProfiling(startTransaction: S
     const transaction: Transaction = startTransaction.call(this, transactionContext, customSamplingContext);
 
     // Client is required if we want to profile
+    // eslint-disable-next-line deprecation/deprecation
     const client = this.getClient() as NodeClient | undefined;
     if (!client) {
       return transaction;

packages/profiling-node/src/hubextensions.ts

@@ -56,6 +56,7 @@ export class ProfilingIntegration implements Integration {
    */
   public setupOnce(addGlobalEventProcessor: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void {
     this.getCurrentHub = getCurrentHub;
+    // eslint-disable-next-line deprecation/deprecation
     const client = this.getCurrentHub().getClient() as NodeClient;
 
     if (client && typeof client.on === 'function') {
@@ -202,6 +203,7 @@ export class ProfilingIntegration implements Integration {
       // If either of them is not available, we remove the profile from the transaction event.
       // and forward it to the next event processor.
       const hub = this.getCurrentHub();
+      // eslint-disable-next-line deprecation/deprecation
       const client = hub.getClient();
       if (!client) {
         if (isDebugBuild()) {

packages/profiling-node/src/integration.ts

@@ -461,6 +461,7 @@ export function applyDebugMetadata(resource_paths: ReadonlyArray<string>): Debug
   }
 
   const hub = Sentry.getCurrentHub();
+  // eslint-disable-next-line deprecation/deprecation
   const client = hub.getClient();
   const options = client && client.getOptions();
 

packages/profiling-node/src/utils.ts

@@ -26,6 +26,7 @@ function makeClientWithoutHooks(): [NodeClient, Transport] {
     integrations: [integration],
     transport: _opts => transport,
   });
+  // eslint-disable-next-line deprecation/deprecation
   client.setupIntegrations = () => {
     integration.setupOnce(
       cb => {
@@ -59,6 +60,7 @@ function makeClientWithHooks(): [NodeClient, Transport] {
       }),
   });
 
+  // eslint-disable-next-line deprecation/deprecation
   client.setupIntegrations = () => {
     integration.setupOnce(
       cb => {

packages/profiling-node/test/hubextensions.hub.test.ts

@@ -36,6 +36,7 @@ function makeClientWithoutHooks(): [NodeClient, MockTransport] {
     integrations: [integration],
     transport: () => transport,
   });
+  // eslint-disable-next-line deprecation/deprecation
   client.setupIntegrations = () => {
     integration.setupOnce(
       cb => {