Skip to content

Commit 8d90b40

Browse files
committed
set ember SDK data globally
1 parent 7c1c937 commit 8d90b40

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

packages/ember/addon/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { macroCondition, isDevelopingApp } from '@embroider/macros';
55
import { next } from '@ember/runloop';
66
import { assert, warn } from '@ember/debug';
77
import Ember from 'ember';
8-
import { timestampWithMs } from '@sentry/utils';
8+
import { setSDKInfo, timestampWithMs } from '@sentry/utils';
99

1010
declare module '@ember/debug' {
1111
export function assert(desc: string, test: unknown): void;
@@ -19,6 +19,7 @@ export function InitSentryForEmber(_runtimeConfig: BrowserOptions | undefined) {
1919
const initConfig = Object.assign({}, config.sentry, _runtimeConfig || {});
2020

2121
createEmberEventProcessor();
22+
setSDKInfo('sentry.javascript.ember', 'npm:@sentry/ember', SDK_VERSION);
2223

2324
Sentry.init(initConfig);
2425

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import { module, test } from 'qunit';
2+
import * as Sentry from '@sentry/ember';
3+
import { getGlobalObject } from '@sentry/utils';
4+
5+
const global = getGlobalObject<Window>();
6+
7+
module('Unit | SDK initialization', function() {
8+
test('adds SDK metadata globally', function(assert) {
9+
// the SDK data is set when we import from @sentry/ember (and therefore run `addon/index.ts`) - it sets the ember
10+
// part itself, and the browser part gets set when it imports from @sentry/browser - so no action is necessary here
11+
// before we run the `assert`s
12+
13+
assert.equal(global.__SENTRY__?.sdkInfo?.name, 'sentry.javascript.ember');
14+
assert.equal(global.__SENTRY__?.sdkInfo?.version, Sentry.SDK_VERSION);
15+
assert.deepEqual(global.__SENTRY__?.sdkInfo?.packages, [
16+
{ name: 'npm:@sentry/browser', version: Sentry.SDK_VERSION },
17+
{ name: 'npm:@sentry/ember', version: Sentry.SDK_VERSION },
18+
]);
19+
});
20+
});

0 commit comments

Comments
 (0)