fix interface + tests

Author: billyvg

packages/replay/src/integration.ts

@@ -79,6 +79,7 @@ export class Replay implements Integration {
   }: ReplayConfiguration = {}) {
     this._recordingOptions = {
       maskAllInputs,
+      maskAllText,
       maskInputOptions: { ...(maskInputOptions || {}), password: true },
       maskTextFn: maskFn,
       maskInputFn: maskFn,
@@ -113,7 +114,6 @@ export class Replay implements Integration {
       sessionSampleRate,
       errorSampleRate,
       useCompression,
-      maskAllText,
       blockAllMedia,
       _experiments,
     };

packages/replay/src/types.ts

@@ -90,11 +90,6 @@ export interface ReplayPluginOptions extends SessionOptions {
    */
   useCompression: boolean;
 
-  /**
-   * Mask all text in recordings. All text will be replaced with asterisks by default.
-   */
-  maskAllText: boolean;
-
   /**
    * Block all media (e.g. images, svg, video) in recordings.
    */
@@ -180,7 +175,7 @@ export interface ReplayConfiguration
   extends ReplayIntegrationPrivacyOptions,
     OptionalReplayPluginOptions,
     DeprecatedPrivacyOptions,
-    Pick<RecordingOptions, 'maskAllInputs'> {}
+    Pick<RecordingOptions, 'maskAllText'|'maskAllInputs'> {}
 
 interface CommonEventContext {
   /**

packages/replay/src/types/rrweb.ts

@@ -30,6 +30,7 @@ export type eventWithTime = {
  * Record<string, unknown> union type.
  */
 export type recordOptions = {
+  maskAllText?: boolean;
   maskAllInputs?: boolean;
   blockClass?: blockClass;
   ignoreClass?: string;

packages/replay/test/integration/integrationSettings.test.ts

@@ -1,4 +1,3 @@
-import { MASK_ALL_TEXT_SELECTOR } from '../../src/constants';
 import { mockSdk } from '../index';
 
 describe('Integration | integrationSettings', () => {
@@ -191,33 +190,28 @@ describe('Integration | integrationSettings', () => {
     it('works with default value', async () => {
       const { replay } = await mockSdk({ replayOptions: {} });
 
-      // Default is true
-      expect(replay['_recordingOptions'].maskTextSelector).toBe(MASK_ALL_TEXT_SELECTOR);
+      expect(replay['_recordingOptions'].maskAllText).toBe(true);
     });
 
     it('works with true', async () => {
       const { replay } = await mockSdk({ replayOptions: { maskAllText: true } });
 
-      expect(replay['_recordingOptions'].maskTextSelector).toBe(MASK_ALL_TEXT_SELECTOR);
+      expect(replay['_recordingOptions'].maskAllText).toBe(true);
     });
 
     it('works with false', async () => {
       const { replay } = await mockSdk({ replayOptions: { maskAllText: false } });
 
-      expect(replay['_recordingOptions'].maskTextSelector).toBe('.sentry-mask,[data-sentry-mask]');
+      expect(replay['_recordingOptions'].maskAllText).toBe(false);
     });
+  });
 
-    it('maskTextSelector takes precedence over maskAllText when not specifiying maskAllText:true', async () => {
+  describe('maskTextSelector', () => {
+    it('can have custom mask selector', async () => {
       const { replay } = await mockSdk({ replayOptions: { maskTextSelector: '[custom]' } });
 
       expect(replay['_recordingOptions'].maskTextSelector).toBe('[custom],.sentry-mask,[data-sentry-mask]');
     });
-
-    it('maskAllText takes precedence over maskTextSelector when specifiying maskAllText:true', async () => {
-      const { replay } = await mockSdk({ replayOptions: { maskAllText: true, maskTextSelector: '[custom]' } });
-
-      expect(replay['_recordingOptions'].maskTextSelector).toBe(MASK_ALL_TEXT_SELECTOR);
-    });
   });
 
   describe('_experiments', () => {

packages/replay/test/integration/rrweb.test.ts

@@ -24,13 +24,14 @@ describe('Integration | rrweb', () => {
         "inlineImages": false,
         "inlineStylesheet": true,
         "maskAllInputs": true,
+        "maskAllText": true,
         "maskInputFn": undefined,
         "maskInputOptions": Object {
           "password": true,
         },
         "maskInputSelector": ".sentry-mask,[data-sentry-mask]",
         "maskTextFn": undefined,
-        "maskTextSelector": "body *:not(style), body *:not(script)",
+        "maskTextSelector": ".sentry-mask,[data-sentry-mask]",
         "slimDOMOptions": "all",
         "unblockSelector": ".sentry-unblock,[data-sentry-unblock]",
         "unmaskInputSelector": ".sentry-unmask,[data-sentry-unmask]",